bug: count connected players without a pawn on SwiftlyS2

apps/player-management-sw/src/PlayerManagementPlugin.cs

@@ -13,6 +13,7 @@
 using SwiftlyS2.Shared.Misc;
 using SwiftlyS2.Shared.Players;
 using SwiftlyS2.Shared.Plugins;
+using SwiftlyS2.Shared.SchemaDefinitions;
 using SwiftlyS2.Shared.ProtobufDefinitions;
 using SwiftlyS2.Shared.Translation;
 
@@ -555,9 +556,24 @@ private static List<ObservedPlayer> Observed(List<IPlayer> humans)
             .ToList();
     }
 
+    // Not IPlayer.IsValid: that also wants a pawn, and a player without one
+    // is still on the server, so the roster ended their session and a gag
+    // stopped applying until they had one again.
     private static bool IsHuman(IPlayer player)
     {
-        return player.IsValid && !player.IsFakeClient && SteamIdOf(player) != 0;
+        CCSPlayerController controller = player.Controller;
+
+        if (!controller.IsValid)
+        {
+            return false;
+        }
+
+        return PlayerRoster.IsConnectedHuman(
+            controller.IsHLTV,
+            controller.Connected == PlayerConnectedState.Connected,
+            player.IsFakeClient,
+            SteamIdOf(player)
+        );
     }
 
     // Before Steam verifies a player only the id they claim is known. Enforcing

apps/player-management-sw/test/PlayerRosterTests.cs

@@ -837,4 +837,14 @@ bool expected
             )
         );
     }
+
+    [Fact]
+    public void CountsEveryConnectedHumanAndNothingElse()
+    {
+        Assert.True(PlayerRoster.IsConnectedHuman(false, true, false, 76561198000000001));
+        Assert.False(PlayerRoster.IsConnectedHuman(false, false, false, 76561198000000001));
+        Assert.False(PlayerRoster.IsConnectedHuman(true, true, false, 76561198000000001));
+        Assert.False(PlayerRoster.IsConnectedHuman(false, true, true, 76561198000000001));
+        Assert.False(PlayerRoster.IsConnectedHuman(false, true, false, 0));
+    }
 }

shared/dotnet/FiveStack.Utilities/PlayerRoster.cs

@@ -274,6 +274,12 @@ public static string Name(string? raw)
         return address.ToString();
     }
 
+    // A connected controller is on the server whether or not it has a pawn.
+    public static bool IsConnectedHuman(bool isHltv, bool connected, bool isBot, ulong steamId)
+    {
+        return !isHltv && connected && !isBot && steamId != 0;
+    }
+
     // Identified by slot, not Steam id: an unverified victim can claim the
     // attacker's id.
     public static bool CountsAsKill(