feature: hide blocked players in chat - #628
Merged
Merged
Conversation
lukepolo
force-pushed
the
feature/chat-reactions
branch
from
September 29, 2026 01:22
d8b5002 to
6978a59
Compare
lukepolo
force-pushed
the
feature/chat-blocks
branch
from
September 29, 2026 01:27
f813db8 to
883f7e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A player you block disappears from your chat right away, on every device, and comes back when you unblock them.
useChatBlockshands theplayer_blockssubscription (feature: block players #626) tosocket.setHiddenAuthors(), which owns the diff so an unblock made while the layout was unmounted is still heard.:chat, history snapshots,:reactionand incoming DMs are filtered for blocked authors; a delete while hidden still sticks.Merge/deploy: pairs with 5stackgg/api#449; merge last, after #624 and #626. Until those land the diff also shows #626 and main's #609–#619.
Tests: the unblock missed on remount, blocked players' reactions (purge, snapshot and live), the on-screen re-badge, the pop-out, the sign-out guard and the incoming-DM reopen each fail with their fix reverted.
Not covered: lines an unblock restores above the "New" divider shift it up.