Skip to content

feature: hide blocked players in chat - #628

Merged
lukepolo merged 3 commits into
mainfrom
feature/chat-blocks
Sep 29, 2026
Merged

lukepolo merged 3 commits into
mainfrom
feature/chat-blocks

Conversation

@lukepolo

@lukepolo lukepolo commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

A player you block disappears from your chat right away, on every device, and comes back when you unblock them.

  • useChatBlocks hands the player_blocks subscription (feature: block players #626) to socket.setHiddenAuthors(), which owns the diff so an unblock made while the layout was unmounted is still heard.
  • On block, their lines leave every open room (badges, the "New" divider and unseen marks follow), their reactions come off visible lines, and the DM tab and pop-out close.
  • Live :chat, history snapshots, :reaction and incoming DMs are filtered for blocked authors; a delete while hidden still sticks.
  • On unblock every open room is rejoined, and a room on screen isn't re-badged by the history that comes back.
  • Signing out isn't read as unblocking everyone.

Merge/deploy: pairs with 5stackgg/api#449; merge last, after #624 and #626. Until those land the diff also shows #626 and main's #609–#619.

Tests: the unblock missed on remount, blocked players' reactions (purge, snapshot and live), the on-screen re-badge, the pop-out, the sign-out guard and the incoming-DM reopen each fail with their fix reverted.
Not covered: lines an unblock restores above the "New" divider shift it up.

@lukepolo
lukepolo force-pushed the feature/chat-reactions branch from d8b5002 to 6978a59 Compare September 29, 2026 01:22
Base automatically changed from feature/chat-reactions to main September 29, 2026 01:22
@lukepolo
lukepolo merged commit 03cabff into main Sep 29, 2026
2 checks passed
@lukepolo
lukepolo deleted the feature/chat-blocks branch September 29, 2026 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant