bug: clip dialogs send no fps or resolution; the api applies the operator's - #636
Merged
Merged
Conversation
…ator's Removes the resolution pickers and clip-setting reads from the clip editor, preset dialog and admin highlight dialog, and puts the Highlights settings page back on the admin-only clip_fps/clip_resolution names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clip fps and resolution stay admin-only settings; the api already enforces them on every render (5stackgg/api#461), so the clip dialogs neither read nor send them.
CreateClipDialog,ClipEditorBarandRenderHighlightForPlayerDialoglose their resolution pickers and settings reads; requests carry no fps, resolution or outputclip_fps/clip_resolutionnames and no longer says users can override the resolution; unusedclips.*.resolutionkeys dropped; zeusClipSpecInput.outputis optionalMerge/deploy: api#461 is merged; deploy it (migration + metadata on boot) before this web, since the editor now omits
output.Tests:
clipOutputOperatorOnly.spec.ts(5) fails on main and passes here; full vitest green, check-translations 16/16.