Skip to content

Add crossorigin for thumbnail images - #19

Merged
alan-wu merged 4 commits into
ABI-Software:mainfrom
akhuoa:bugfix/coep
Oct 18, 2026
Merged

alan-wu merged 4 commits into
ABI-Software:mainfrom
akhuoa:bugfix/coep

Conversation

@akhuoa

@akhuoa akhuoa commented Oct 12, 2026

Copy link
Copy Markdown
Member

No description provided.

@akhuoa
akhuoa requested a review from alan-wu October 13, 2026 00:05

@alan-wu alan-wu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After thinking through it a bit more, I think it will be better to have anonymous as default but allow the user to change it through a prop or from the data sent to the gallery so we can get a per-item option (Not required at this stage however).

@akhuoa
akhuoa requested a review from alan-wu October 15, 2026 23:37
@akhuoa

akhuoa commented Oct 15, 2026

Copy link
Copy Markdown
Member Author

After thinking through it a bit more, I think it will be better to have anonymous as default but allow the user to change it through a prop or from the data sent to the gallery so we can get a per-item option (Not required at this stage however).

@alan-wu, I've updated it in 00d9c8f.

@alan-wu alan-wu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@alan-wu
alan-wu merged commit d4f1c5b into ABI-Software:main Oct 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants