Repository navigation
Fix curve - trim surface intersections - #296
Merged
Merged
Conversation
mlin865
approved these changes
Oct 4, 2026
mlin865
left a comment
mlin865
left a comment
Contributor
There was a problem hiding this comment.
Thanks, uterus scaffolds are back to normal and passed all tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wasn't finding best initial guess for surface-curve intersections.
Also fixed logic for optimising intersection initial point search so it gives up after nearest distance is greater than [now] twice the current nearest distance, since it's an inexact calculation from sampled curve and nearest parameter locations on the track surface.