Encapsulate lifecycle management and unify metrics logging in MaxTextTrainingEngine - #4738
Open
copybara-service[bot] wants to merge 1 commit into
Open
Encapsulate lifecycle management and unify metrics logging in MaxTextTrainingEngine#4738copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
…TrainingEngine - Add internal goodput event recording (TPU_INIT and STEP) inside MaxTextTrainingEngine. - Support custom input generation via _gen_model_input_fn and filter auxiliary non-metric tensors in fwd_bwd. - Encapsulate XLA compiler HLO dump uploading, profiler lifecycle, step timing, and TFLOPS recording internally within MaxTextTrainingEngine. - Unify setup and runtime step metrics logging under metrics_module.MetricsLogger, removing dependency on legacy MetricLogger. PiperOrigin-RevId: 959402235
copybara-service
Bot
requested review from
A9isha,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
huytransformer,
igorts-git,
jiangjy1982,
khatwanimohit,
richjames0,
shralex,
shuningjin,
vipannalla and
xibinliu
as code owners
August 5, 2026 04:36
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encapsulate lifecycle management and unify metrics logging in MaxTextTrainingEngine