Repository navigation
Require Hermes profile consent and isolate backup restoration - #102
Merged
Merged
Conversation
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A minimal Hermes configuration could rewrite the wrong profile on every startup, while restore selected a backup shared by all profiles. Require explicit
hermes.configureconsent and a persistedhermes.config_path; setup proposes environment-aware paths and optionally imports literal upstream settings before mutation. Skills defaults, diagnostics, backup and restore now use the same selected profile. Refuse writes without a usable upstream, valid YAML or a successful backup, and skip unchanged files.Fixes #71. Builds on the path-selection problem identified in #72, and additionally isolates backup/restore and integrates setup consent/import. Existing Hermes users must rerun setup or explicitly configure the new fields; legacy global backups require manual inspection/restoration. OAuth and unresolved secret references are not imported.
Validation: 12 new regression cases; full suite 200 passed, 1 skipped; Ruff and diff checks passed. No live Hermes/provider requests were used.