Repository navigation
fix: reject bucket paths in Cloudflare R2 endpoints - #98
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An R2 endpoint containing the bucket path duplicates boto3's Bucket parameter and can fail with NoSuchKey during listing (#33). Reject non-root R2 endpoint paths before constructing a storage session, with an actionable message. Preserve generic S3 reverse-proxy paths. Document account endpoints and region=auto in both guides.
Validation: 7 endpoint tests plus existing bundle tests; no live R2 credentials used. The check covers the misconfiguration visible in #33; a remaining service failure with a correct endpoint still requires its sanitized response.
Refs #33.