Repository navigation
cmsis_dsp: Use float16_t in MVE arm_barycenter_f16 - #352
Open
matthewbstokes-zz wants to merge 1 commit into
Open
matthewbstokes-zz wants to merge 1 commit into
matthewbstokes-zz wants to merge 1 commit into
Conversation
- Restore float16_t for accum, w, and w1-w4 in the MVE branch of arm_barycenter_f16 to resolve _Generic selector mismatch with ARM MVE vector-by-scalar intrinsics. Signed-off-by: Matt Stokes <matthewbstokes@google.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #351
Problem Statement
In
Source/SupportFunctions/arm_barycenter_f16.c,accum,w, andw1–w4inside the MVE implementation are declared as_Float16.When compiling with MVE enabled (e.g. Cortex-M55 / Cortex-M85 / Armv8.1-M.main) using Clang or GCC, passing
_Float16variables into MVE vector-by-scalar intrinsics (vfmaq_n_f16,vmulq_n_f16) causes a compilation error because the_Genericmacro selector does not match the scalar type:Solution
Change
accum,w, andw1–w4from_Float16tofloat16_tinSource/SupportFunctions/arm_barycenter_f16.c. This matches the parameter types and the conventions used throughout the other MVE DSP functions, resolving the build failure.