Repository navigation
Add arm_cmplx_mult_real_f64 - #353
Open
Kiptoo-Deus wants to merge 1 commit into
Open
Kiptoo-Deus wants to merge 1 commit into
Kiptoo-Deus wants to merge 1 commit into
Conversation
The complex math functions have f64 versions of mag, mag_squared and mult_cmplx, but not of mult_real. Add arm_cmplx_mult_real_f64 as a scalar implementation like the other f64 functions, declare it in complex_math_functions.h and add it to ComplexMathFunctions.c and Config.cmake. The F64 complex test suite already has test_cmplx_mult_real_f64, its setUp cases and the Reference8_f64.txt pattern, so the four disabled mult_real_f64 tests in desc.txt are enabled. Fixes ARM-software#350.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #350.
The complex math functions have f64 versions of
mag,mag_squaredandmult_cmplx, but not ofmult_real. This addsarm_cmplx_mult_real_f64:Source/ComplexMathFunctions/arm_cmplx_mult_real_f64.c: a scalar implementation, like the other f64 complex functions, documented in the existingCmplxByRealMultgroup.Include/dsp/complex_math_functions.hnext toarm_cmplx_mult_cmplx_f64.ComplexMathFunctions.candConfig.cmake.Testing/desc.txt: the F64 complex suite already hastest_cmplx_mult_real_f64, its setUp cases (nb = 2, 4, 5 and the long test) and theReference8_f64.txtpattern, but the four tests were disabled because the function didn't exist. They're enabled now.Testing (macOS, Apple clang):
Input1_f64.txt(complex) andInput3_f64.txt(real) for nb = 2, 4, 5 and 256, the sizes the test cases use, and compared withReference8_f64.txt: the output is bit-exact in every case, built for both arm64 and x86_64, and nothing is written past the end of the output.ComplexMathFunctions.cand the CMake build ofSource(CMSISDSP static library) both build, witharm_cmplx_mult_real_f64exported.I didn't add Python wrapper or dsppp bindings for it; happy to do that in a follow-up if you'd like.