Repository navigation
Saturate Q15 variance results before narrowing - #355
Open
Firat17aze wants to merge 1 commit into
Open
Firat17aze wants to merge 1 commit into
Firat17aze wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #354.
arm_var_q15documents that its 34.15 result is saturated to 1.15, but both the scalar and MVE paths assigned the shifted value directly toq15_t. A valid sample variance above 1.0 could therefore narrow to a negative result. This applies__SSAT(..., 16)before the assignment, matching the existingarm_std_q15behavior.Validation:
HOST=ONandDISABLEFLOAT16=ONusing AppleClang 21.-O0and at-O3 -ffast-mathwith loop unrolling.[0.75, -0.75]now saturates to32767; an in-range case and the single-sample case remain unchanged.libCMSISDSP.a.git diff --checkpasses.No Arm hardware testing was performed, and the MVE path was not executed locally.
LLMs were used for review and code generation in some parts of this pull request.