Repository navigation
ci(release): build the documentation of a completed release from its tag's commit - #242
Merged
Merged
Conversation
…tag's commit deploy-docs.yml builds a tag only when it descends from the run's commit, which holds for a release, run from the commit before its tag, but not for one completed from main, whose tag is an ancestor: the completion of 0.3.0 published the release, then failed to build its documentation. The resume job hands the tag's full SHA, which deploy-docs.yml accepts as an ancestor of the run's commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018bXdF3LqPfoQDtE8WnZkcW
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018bXdF3LqPfoQDtE8WnZkcW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
complete: v0.3.0run (40836380247) did what #241 intended:resumeandattest provenancesucceeded, and the 0.3.0 release is now published with its attestation. Onlypublish documentation / buildfailed:deploy-docs.ymlaccepts a tag only when it descends from the run's commit. In a normal release this holds, because the run starts on the commit before the tag. A run that completes a release starts frommain, where the tag is an ancestor, so the check refused it.What
resumenow also outputs the full SHA of the tag's commit, andpublish documentationpasses that instead of the tag.deploy-docs.ymlaccepts it as an ancestor of the run's commit. The build is the same, anddeploy-docs.ymlis unchanged.For 0.3.0
The release is already published, so
completewould now refuse it. To deploy its documentation, dispatch preview frommain, asdocs/maintaining.mddescribes: the site is redeployed frommain, whose history includes the release commit and its snapshot.Generated by Claude Code