Donor-set waiting period on delegated spends - #197
Merged
Merged
Conversation
A scheduled spend on the note can be flagged, paused in strict mode, revoked, or released early; recurring pledges carry the same policy onto each new note.
Scheduling and completion both require the current quote to equal the note balance, so a partial count cannot lock the note and then leave a remainder.
AdamSpitz
commented
Sep 26, 2026
AdamSpitz
left a comment
Owner
Author
There was a problem hiding this comment.
Review receipt.
Same review as the closed stacked PR #196, now retargeted onto dev after #195 merged. Waiting-period schedule, pause, revoke, replace, recurring-pledge copy, split fold, and flag notifier. A scheduled spend must cost the whole note. Refund and reimbursement notes still mint with delay zero; refund authority stays out of scope.
Reviewed-with: grok
Reviewed-files: 20
Reviewed-commit: a21f4e4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PR #196 closed when its base branch misc was deleted by the merge of #195. This retargets that same branch onto dev.
A delegated spend is scheduled on the existing note. The donor sets the delay (including zero), can revoke or release early, and can opt into a strict mode where a trusted flag pauses the clock. Recurring pledges copy that policy onto each new note. A schedule is rejected unless its current price equals the whole note.