Classify delegated spends and let a donor take part of a note back - #198
Merged
Merged
Conversation
… beneficiary. A donor names beneficiary ids and a shorter unsuspicious delay. Only a market whose payout registry reports that id as the current controller uses that shorter wait; every other spend keeps the standing delay. ADR 0017 records the decision, and recurring pledges copy the fine list onto each new note.
Note and project screens treat a scheduled spend as cancellable money, not raised funds. Donors can set the delay, strict mode, and flaggers, and a banner points at suspicious spends that are still pending.
…he blocking rules for delegated funds.
…egation. The slice is a new root-only note. The original note stays delegated, a pending spend blocks the call, and the notes pages expose the control.
…review gaps. The factory only accepts its deployed payout registry. Pending deadlines keep the standing delay from schedule time, the indexer watches the new factory, and the one-hop revoke integration test matches the hop limit.
AdamSpitz
commented
Sep 27, 2026
AdamSpitz
left a comment
Owner
Author
There was a problem hiding this comment.
Review receipt.
Reviewed the branch against origin/dev, including the uncommitted review fixes now in 2a1f353. Fixed registry pinning, pending-deadline snapshots, indexer factory discovery, receipt waits, currency formatting, and the stale two-hop revoke integration test. No open findings. Deferred pledge fine-list UI and donor notification delivery, already on TODO.md. Integration 106 passing; no browser pass.
Reviewed-with: grok
Reviewed-files: 70
Reviewed-commit: 2a1f353
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recurring-pledge fine-list and unsuspicious-delay controls, and donor notification delivery, stay on the to-do list. The contract already stores the pledge policy; the product controls still edit individual notes.
Validation
automated.test-full-integration: 106 passing, 1 pending (run2026-09-27T00-36-42.212Z-b5d019cb), after the one-hop revoke test was updated to matchDelegationHopLimit.automated.test-fastpassed.Local indexer Compose now sets
CHOKIDAR_USEPOLLING=true. This host's inotify instance cap is 128, and Ponder's file watcher otherwise dies withEMFILEbefore the integration suite can start. That matches the Render indexer workaround.