Apply pledge spend rules before the first note and cover descendant Takebacks - #199
Merged
Merged
Conversation
Creation writes the list and the shorter delay before minting, and both deposit paths collect names that can be paid immediately. The pledge page edits what future notes inherit.
revokeMany skips notes that are already gone. The client walks that closure from the logs and confirms which delegated notes to revoke. A purchase or refund copies the source note's spend rules onto the new note.
AdamSpitz
commented
Sep 27, 2026
AdamSpitz
left a comment
AdamSpitz
left a comment
Owner
Author
There was a problem hiding this comment.
Review receipt.
Reviewed the pledge policy initialization, receipt and refund policy copying, revocation closure, UI flows, and regression tests. The fine-list getter ABI mismatch was fixed before this review; no remaining findings.
Reviewed-with: codex
Reviewed-files: 47
Reviewed-commit: f47312b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new standing pledge now stores its spend wait, listed payees, and shorter listed-payee wait before minting its first note. The deposit and pledge screens expose those rules, and Takeback can cover active receipt and refund notes descended from the selected note. Review also restored the recurring pledge fine-list getter name expected by the SDK and indexer ABIs.
Validation: targeted Hardhat pledge/refund tests passed; pre-commit lint, build, and fast tests passed.