Skip to content

Land reimbursement rounding, campaign gas cushion, and branch cleanup - #202

Merged
AdamSpitz merged 3 commits into
devfrom
feature/fold-reimbursement-rounding
Sep 28, 2026
Merged

AdamSpitz merged 3 commits into
devfrom
feature/fold-reimbursement-rounding

Conversation

@AdamSpitz

Copy link
Copy Markdown
Owner

Summary

  • Replay the assurance-contract claim-share accumulator in foldReimbursements, so forgo and withdrawable amounts match on-chain views when a donation does not divide evenly.
  • Cut the fake-data campaign wallet native buffer from 0.05 ETH to 0.001 ETH. It is gas slack, and 0.05 ETH per wallet made a 10-user canary look like it needed about 1 ETH.
  • Tell agents to switch back to dev and delete the local feature branch after a PR lands.

Retroactive donations now accrue on the scaled per-share accumulator, and purchases mint ceiling shares, so forgo and withdrawable amounts follow the contract views when a donation does not divide evenly.
After a PR lands, leave local dev checked out and delete that local feature branch. Do not keep merged branches around.

@AdamSpitz AdamSpitz left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review receipt.

Reviewed the three commits against origin/dev. foldReimbursements now mints ceiling claim-shares and accrues donations on the 1e36 accumulator, matching AssuranceContracts withdrawable and future-claim views; the two new remainder tests cover an indivisible 1-wei donation and a ceiling mint. The campaign buffer change is a constant plus the matching assertions. The branching.md edit only tells agents to return to dev and delete the merged local branch. No findings.

Reviewed-with: grok
Reviewed-files: 5
Reviewed-commit: f811351

@AdamSpitz
AdamSpitz merged commit 464ec30 into dev Sep 28, 2026
7 checks passed
@AdamSpitz
AdamSpitz deleted the feature/fold-reimbursement-rounding branch September 29, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant