Land reimbursement rounding, campaign gas cushion, and branch cleanup - #202
Merged
Merged
Conversation
Retroactive donations now accrue on the scaled per-share accumulator, and purchases mint ceiling shares, so forgo and withdrawable amounts follow the contract views when a donation does not divide evenly.
After a PR lands, leave local dev checked out and delete that local feature branch. Do not keep merged branches around.
AdamSpitz
commented
Sep 28, 2026
AdamSpitz
left a comment
Owner
Author
There was a problem hiding this comment.
Review receipt.
Reviewed the three commits against origin/dev. foldReimbursements now mints ceiling claim-shares and accrues donations on the 1e36 accumulator, matching AssuranceContracts withdrawable and future-claim views; the two new remainder tests cover an indivisible 1-wei donation and a ceiling mint. The campaign buffer change is a constant plus the matching assertions. The branching.md edit only tells agents to return to dev and delete the merged local branch. No findings.
Reviewed-with: grok
Reviewed-files: 5
Reviewed-commit: f811351
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
foldReimbursements, so forgo and withdrawable amounts match on-chain views when a donation does not divide evenly.devand delete the local feature branch after a PR lands.