Repository navigation
chore(calendar): the repeating-event dialog's parts, not yet shown → 3.148.9-alpha (C9b-1a of #884) - #960
Merged
BBYU26 merged 4 commits intoOct 22, 2026
Conversation
BBYU26
force-pushed
the
chore/calendar-series-dialog-parts
branch
from
October 20, 2026 21:01
8f7764e to
146067c
Compare
…3.148.8-alpha (C9b-1a of #884) The "which occurrences?" dialog for a repeating event is built and tested but not mounted: the pure rules and words (saveChoices.ts), the SaveChoicesDialog, the store's choices, scoped writes and settling in useEventWrites, and settle buttons on WriteNotices. Repeating events stay read-only and release builds still refuse scoped writes. Backend: a one-off Google has turned into a series is read-only with its own reason (BecameRepeating) on every path; a delete's choices that meet a changed occurrence land Google's copy; every orphan's words are said; a settle that leaves the change held answers PartialSplit with a note, so its buttons stay; one release gate for a missing choice, pinned by a source test; no jargon in what rows show. The one visible change: the became-repeating reason's wording. Part of #884 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…are announced; notices wrap only with settle buttons Review round 1 of C9b-1a: saveEdit's title is required, so a partial notice can't read "(no title)"; the choices dialog's refusal, which arrives after it opened, is a live region whatever its tone; only a notice with settle buttons wraps them under its words, so other notices look as before; a settle with no answer keeps its notice's own offers (now tested); and the What's New line no longer says the event was made in PM. Part of #884 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review round 2 of C9b-1a: PM's own claim now reaches a settle as a held change with a note, so a plain busy answer only comes from Google refusing Finish's next step, after which PM took the new part back. Its words said PM was still changing the event; they now say it was put back as it was. Part of #884 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
BBYU26
force-pushed
the
chore/calendar-series-dialog-parts
branch
from
October 21, 2026 15:37
146067c to
c26d070
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #884. C9b-1a, the first half of C9b-1: the dialog that asks which occurrences of a repeating event you mean, built and tested but not shown yet. 3.148.9-alpha (renumbered from 3.148.8 on 21-10, when #959 moved onto #968). Stacked on #959: the base is
chore/calendar-split-journal, and there's no closing link while the base isn't main.What it builds
Backend (safe on its own):
BecameRepeating). This covers opening it, saving it, deleting it and planning a change, and it comes before the existingRecurringreason, which stays.partial_splitwith anote, so the notice keeps its buttons.MISSING_CHOICE_OKgate for the three shells, with a test that reads the source.Frontend:
saveChoices.ts: the rows, the default pick, warning lines and the repeat-day question.SaveChoicesDialog: built, not mounted.useEventWritesstore: choices, scoped saves and deletes, settling, and partial notices that outlive the Calendar tab.WriteNoticesaction buttons (Finish / Remove the new part / Check again).editReasons.Nothing changes for you yet: repeating events stay read-only, and release builds still refuse scoped writes and settling. The one visible change is that a one-off turned repeating in Google now says so.
Decisions taken while you were away (recommendations from the spec)
Recurringand mounts the dialog, so main never shows Edit on a repeating event without it.Reviews
Each guard was checked by breaking it and seeing a test fail.
Checks
The full
just checkpasses at the tip: 2,105 Rust tests and 2,065 frontend tests.🤖 Generated with Claude Code