Repository navigation
test(probe): run the vendor-wait test without httpx installed - #58
Merged
Merged
Conversation
_collect_cli imports httpx before it starts any vendor, so on a Python without httpx the test got the 'probe cannot import httpx' snapshot instead of the slow Anthropic card. The fetcher is faked, so a stub module is enough. CI installs httpx, which hid this; the README says the runtime tests need no packages.
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_vendor_wait_ends_before_the_gateway_shell_limitfailed on a Python withouthttpxinstalled, with['resetwatch'] != ['anthropic']. @Iversondwx reported it in #57._collect_cliimportshttpxbefore it starts any vendor. When the import fails, it returns theprobe cannot import httpxsnapshot instead of running the slow Anthropic fetch that the test covers. CI installshttpxbefore the Python tests, which hid this. The README's Contributing section says the runtime tests need no packages.The test now patches a stub
httpxmodule intosys.modules. The vendor fetcher is already faked, so the import only has to succeed. The probe code is unchanged.Testing:
httpxblocked, the test failed for both the standalone and catalog probes before this change, and passes after it.Catalog packageworkflow steps pass locally:build_catalog.py --check, the catalog policy test, 85 Python tests, 102 Node tests, 36 catalog-mode Python tests and 74 catalog-mode Node tests.