refactor(frontend): drop the app-layer re-export shims left by the carve waves - #5887
Draft
ardaerzin wants to merge 1 commit into
Draft
refactor(frontend): drop the app-layer re-export shims left by the carve waves#5887ardaerzin wants to merge 1 commit into
ardaerzin wants to merge 1 commit into
Conversation
Contributor
Author
|
@coderabbitai review |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe change centralizes frontend imports on shared workspace packages. It migrates date-time, settings, navigation, project, authentication, chat, and webhook dependencies, removes compatibility paths, and updates application style and import ordering. ChangesShared import migration
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ardaerzin
force-pushed
the
pkg/ui-data-table
branch
from
August 10, 2026 14:59
8a13b53 to
d70dc9f
Compare
ardaerzin
force-pushed
the
oss/drop-reexport-shims
branch
from
August 10, 2026 14:59
5065141 to
e32f4af
Compare
ardaerzin
force-pushed
the
pkg/ui-data-table
branch
from
August 10, 2026 15:14
d70dc9f to
8942568
Compare
ardaerzin
force-pushed
the
oss/drop-reexport-shims
branch
from
August 10, 2026 15:14
e32f4af to
5bd011e
Compare
Contributor
Author
|
@coderabbitai review |
✅ Action performedReview finished.
|
…rve waves Each extraction wave left a stub at the old app path re-exporting the package, so call sites never moved. OSS lint forbids exactly that (it defeats tree-shaking), and the gate had been red since the navigation wave. All 24 shims are gone and their 60 call sites now import the package directly. Two needed more than a path swap: SettingsPageShell was a default re-export, and services/api.ts re-exported fetchProfile out of a module the caller also used for getJWT. Also fixes an unrelated pre-existing break: seven files imported dayjs from lib/helpers/dateTimeHelper/dayjs, a path that has never existed in git. They were silently untyped, which is where all 23 of the OSS type errors came from. They now take the plugin-configured instance, newly re-exported from @agenta/shared/utils/dateTime. EE gained the @agenta/settings dep the repointing exposed. Gates: lint 24/24, OSS tsc 0 errors (was 23), EE tsc 0. In _app.tsx the CSS imports keep their original order — globals.css before the vendor sheets — since the cascade depends on it.
ardaerzin
force-pushed
the
pkg/ui-data-table
branch
from
August 11, 2026 05:11
8942568 to
88298de
Compare
ardaerzin
force-pushed
the
oss/drop-reexport-shims
branch
from
August 11, 2026 05:11
5bd011e to
1727819
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each extraction lane left a stub in the app that re-exported from the package, to keep call sites
compiling. This lane deletes those 24 stubs and repoints roughly 60 call sites at the packages.
Wide (108 files) but mechanical — the alternative is leaving a permanent second name for every
moved symbol.
Not run in a browser — static gates only (
pnpm lint-fix24/24,tsc --noEmitcleanfor
@agenta/shared,ui,entities,entity-ui,settings-ui,oss,ee,mobile).Stacked on
pkg/ui-data-table; review only this lane's diff.