Repository navigation
build: leave the plugin tests out of the code package - #178
Merged
Merged
Conversation
The tests change PlayerSettings, so they must not run in game projects. The upgrade deletes the Tests folder that 2.6.3 and earlier installed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015uK9hhtA5vxmCSveT2uQm3
NDreamAlex
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code package no longer ships
Assets/AirConsole/scripts/Tests. The tests change PlayerSettings, so they must not run in game projects.scripts/exceptTests, plusunity-webviewandexamples.Testsfolder that 2.6.3 and earlier installed. The check finds that folder byAirConsole.EditMode.Tests.asmdef. Without it, a stale copy that compiles against internal members would break compilation after a later release.Testing (Unity 2022.3.62f3, batch mode, package exported from this branch):
scripts/Testson diskTestsentries removed, nothing elseIn every run, ProjectCodeUpdater finished and deleted itself and the code package. The test projects had
com.unity.ugui1.0.0,com.unity.textmeshpro3.0.9 andcom.unity.test-framework1.4.4 added, because a project made with-createProjecthas no UI packages and the plugin does not compile without them (2.6.3 also).