Repository navigation
test(cli): strip inherited color vars from the CLI child env - #4
Merged
Merged
Conversation
`node --test` sets FORCE_COLOR=1 for its test files when its own stdout is a color TTY. runCli spread process.env into the CLI child, so an interactive `pnpm test` / `pnpm publish` colorized the CLI's tables and three converge tests matching plain table text failed locally while CI stayed green. runCli now starts from process.env minus FORCE_COLOR, NO_COLOR, MIGRONAUT_FORCE_COLOR and MIGRONAUT_NO_COLOR; tests that want color pass the variables explicitly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node --testsets FORCE_COLOR=1 for its test files when its own stdout is a color TTY. runCli spread process.env into the CLI child, so an interactivepnpm test/pnpm publishcolorized the CLI's tables and three converge tests matching plain table text failed locally while CI stayed green.runCli now starts from process.env minus FORCE_COLOR, NO_COLOR, MIGRONAUT_FORCE_COLOR and MIGRONAUT_NO_COLOR; tests that want color pass the variables explicitly.