Repository navigation
fix(ems): improve telemetry, deduplicate commands and fix setpoint quantization - #189
Open
StefanoPierini wants to merge 3 commits into
Open
StefanoPierini wants to merge 3 commits into
StefanoPierini wants to merge 3 commits into
Conversation
…antization
- Deduplicate outgoing MQTT commands (selflowtemp, burnmaxpower) to prevent flooding EMS-ESP every 5 seconds.
- Do not toggle 'heatingactivated' in async_set_heater_state, avoiding unintended boiler Summer/Winter mode transitions that trigger the 15-minute Siphon Filling Program on Buderus/Bosch boilers.
- Map idle flow setpoint (0°C) to MINIMUM_SETPOINT to prevent false positive sync alarms when heating is idle.
- Expand hot_water_active detection to include EMS-ESP telemetry ('tapwateractive', 'dhwcharging', 'dhw_charging') with robust boolean truthy check.
- Suppress heating setpoint overrides during active DHW production to preserve DHW priority.
- Send integer-rounded flow setpoints (matching EMS telegram 1°C resolution) and bridge float quantisation to prevent control_setpoint_synchro false alarms.
- Maintain a 30-second safety keepalive heartbeat for active heating setpoint.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review: 1
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
… timeout EMS-ESP firmware has a ~4-minute safety timeout on thermostat flow setpoints. A 60s keepalive interval ensures regular setpoint updates before EMS-ESP falls back to 0, preventing unintended burner cutoffs and short-cycling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR improves stability and telemetry handling for Energy Management System (EMS/EMS-ESP) boilers:
Deduplicate Outgoing MQTT Commands:
selflowtempandburnmaxpowerto prevent flooding the EMS-ESP gateway every 5 seconds.Do Not Toggle
heatingactivatedon EMS Boilers:heatingactivatedcontrols the master Summer/Winter mode (Heizbetrieb ein/aus).async_set_heater_stateto super, keeping central heating control strictly driven byselflowtemp(>0 for demand, 0 for idle) as native EMS room thermostats do.Bridge Float Quantization and Integer Rounding:
int(round(value))) and bridges the reported integer back to the internal target when matching, eliminating persistent oscillations and false alarms oncontrol_setpoint_synchro(e.g.51.9 != 52).Dynamic DHW Telemetry & DHW Priority:
hot_water_activedetection to dynamically detecttapwateractive,dhwcharging, anddhw_chargingwith robust boolean truthy check.MINIMUM_SETPOINT(10.0°C) to prevent false sync alarms during heating idle periods.