Repository navigation
fix(core): suppress sync false positives and fix boiler status during DHW production - #190
Open
StefanoPierini wants to merge 1 commit into
Open
StefanoPierini wants to merge 1 commit into
StefanoPierini wants to merge 1 commit into
Conversation
… DHW production - Suppress false-positive mismatch alarms on SatControlSetpointSyncSensor, SatRelativeModulationSyncSensor and SatCentralHeatingSyncSensor while hot_water_active is True. - In DeviceStatusEvaluator, evaluate state.hot_water_active before checking central_heating, correctly classifying boiler status as HEATING_HOT_WATER instead of OFF when DHW has heating priority.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review: 1
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR addresses synchronization false alarms and improper boiler status classification during domestic hot water (DHW) production:
Suppress Sync False Alarms during DHW:
heatingactive: off).control_setpoint_synchro,relative_modulation_synchro, andcentral_heating_synchrosensors to enter problem state due to setpoint mismatch.hot_water_activeis true.Fix Boiler Status Evaluation:
status.py,state.hot_water_activeis now evaluated before checkingcentral_heating.BoilerStatus.OFFinstead ofBoilerStatus.HEATING_HOT_WATER.NOTE: I had only the opportunity to test the code with a single EMS boiler.