[OCTRL-1091] OCC_CONTROL_PORT removal from TaskTemplate CRDs#841
Open
justonedev1 wants to merge 1 commit into
Open
[OCTRL-1091] OCC_CONTROL_PORT removal from TaskTemplate CRDs#841justonedev1 wants to merge 1 commit into
justonedev1 wants to merge 1 commit into
Conversation
…mplate The reason for the removal is that ECS can assign OCC_CONTROL_PORT only for mesos tasks, thus the removal here. The variable is now set inside the TaskTemplates. Ability to overwrite EnvVars from TaskReference CRDs was also added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core provides
OCC_CONTROL_PORTvariable only for Mesos tasks, where it is generated by Mesos. However, TaskTemplate CRD needed this variable to be filled in by during usage by TaskReference. So I moved theOCC_CONTROL_PORTsetup directly into the TaskTemplate CRD to not rely on core at all. This approach is ok, because when we have non-host networking for containers we can basically setup any port because those would not clash thanks to k8s internal networking. But for now we manually setup unique ports in each TaskTemplate because we use host network.