Skip to content

[PWGJE] pvalue check on rho(phi)#17106

Open
joachimckh wants to merge 5 commits into
AliceO2Group:masterfrom
joachimckh:jet-had-dev-pval-1
Open

[PWGJE] pvalue check on rho(phi)#17106
joachimckh wants to merge 5 commits into
AliceO2Group:masterfrom
joachimckh:jet-had-dev-pval-1

Conversation

@joachimckh

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the pwgje label Jul 17, 2026
@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 1 errors, ⚠️ 0 warnings, 🔕 2 disabled

@joachimckh
joachimckh marked this pull request as ready for review July 17, 2026 11:16
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 05ebb3e at 2026-07-17 13:36:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 19 errors and 70 warnings.'
Found 19 errors and 70 warnings.
++ [[ 19 -gt 0 ]]
++ cat /sw/BUILD/6015116bd04511b1c709e400e902a25df08bc414/O2Physics-code-check/errors.txt
PWGJE/Tasks/jetSpectraEseTask.cxx:70:8: error: constructor does not initialize these fields: ccdb, pdg [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGJE/Tasks/jetSpectraEseTask.cxx:234:51: error: use designated initializer list to initialize 'EventPlaneFiller' [modernize-use-designated-initializers,-warnings-as-errors]
PWGJE/Tasks/jetSpectraEseTask.cxx:235:52: error: use designated initializer list to initialize 'EventPlaneFiller' [modernize-use-designated-initializers,-warnings-as-errors]
PWGJE/Tasks/jetSpectraEseTask.cxx:236:54: error: use designated initializer list to initialize 'EventPlaneFiller' [modernize-use-designated-initializers,-warnings-as-errors]
PWGJE/Tasks/jetSpectraEseTask.cxx:627:5: error: redundant return statement at the end of a function with a void return type [readability-redundant-control-flow,-warnings-as-errors]
PWGJE/Tasks/jetSpectraEseTask.cxx:631:31: error: the parameter 'track' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGJE/Tasks/jetSpectraEseTask.cxx:645:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGJE/Tasks/jetSpectraEseTask.cxx:988:22: error: narrowing conversion from 'unwrap_t<float>' (aka 'float') to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGJE/Tasks/jetSpectraEseTask.cxx:1092:12: error: implicit conversion 'TParticlePDG *' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGJE/Tasks/jetSpectraEseTask.cxx:1292:12: error: use designated initializer list to initialize 'EventPlane' [modernize-use-designated-initializers,-warnings-as-errors]
PWGJE/Tasks/jetSpectraEseTask.cxx:1349:13: error: member 'secondHarmonic' of type 'const int' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGJE/Tasks/jetSpectraEseTask.cxx:1351:36: error: the parameter 'collision' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGJE/Tasks/jetSpectraEseTask.cxx:1378:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGJE/Tasks/jetSpectraEseTask.cxx:1379:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGJE/Tasks/jetSpectraEseTask.cxx:1387:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGJE/Tasks/jetSpectraEseTask.cxx:1388:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGJE/Tasks/jetSpectraEseTask.cxx:1439:19: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
PWGJE/Tasks/jetSpectraEseTask.cxx:1449:26: error: use std::make_unique instead [modernize-make-unique,-warnings-as-errors]
PWGJE/Tasks/jetSpectraEseTask.cxx:1521:52: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
++ [[ 70 -gt 0 ]]
++ cat /sw/BUILD/6015116bd04511b1c709e400e902a25df08bc414/O2Physics-code-check/warnings.txt
PWGJE/Tasks/jetSpectraEseTask.cxx:643:18: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:645:9: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:662:63: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:668:22: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:674:19: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:679:62: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:691:118: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:720:74: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:722:66: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:725:22: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:736:20: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:746:72: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:748:33: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:777:33: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:779:33: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:781:114: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:783:114: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:786:57: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:788:57: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:793:65: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/jetSpectraEseTask.cxx:796:66: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants