Skip to content

Fix reward unit and code version in mapper - #200

Merged
micahwoodard merged 6 commits into
mainfrom
fix-workspace-metadata-211-216
Sep 30, 2026
Merged

micahwoodard merged 6 commits into
mainfrom
fix-workspace-metadata-211-216

Conversation

@micahwoodard

@micahwoodard micahwoodard commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Fix reward unit and code version in mapper.

Rewards are now measured in ul like legacy system

code is versioned better and tried to be less confusing. The results are below.

Per @rachelstephlee comments:

The same code base seems to be referenced 3 times

bonsai, acquisition, and curriculum code are all contained in the Aind.Behavior.DynamicForaging code base. The curriculum is a sub package and is version independently. Bonsai version is also versioned independently

In addition, the branch information is not listed, which we should include because it's much more accessible than a commit hash

It doesn't seem like the branch name is a part of the Code object

"code": [
            {
               "object_type": "Code",
               "url": "git@github.com:AllenNeuralDynamics/Aind.Behavior.DynamicForaging.git",
               "name": "Aind.Behavior.DynamicForaging",
               "version": "0.0.3",
               "commit_hash": "84120c95ce81dddcf403f535fa7740c2e48cf979",
               "container": null,
               "run_script": "C:\\Users\\micah.woodard\\Documents\\GitHub\\Aind.Behavior.DynamicForaging\\src\\main.bonsai",
               "language": "Bonsai",
               "language_version": "2.9.1",
               "input_data": null,
               "parameters": null,
               "core_dependency": null
            },
            {
               "object_type": "Code",
               "url": "git@github.com:AllenNeuralDynamics/Aind.Behavior.DynamicForaging.git",
               "name": "aind-behavior-dynamic-foraging",
               "version": "0.0.3",
               "commit_hash": "84120c95ce81dddcf403f535fa7740c2e48cf979",
               "container": null,
               "run_script": null,
               "language": "Python",
               "language_version": "3.13.11",
               "input_data": null,
               "parameters": null,
               "core_dependency": null
            },
            {
               "object_type": "Code",
               "url": "git@github.com:AllenNeuralDynamics/Aind.Behavior.DynamicForaging.git",
               "name": "aind_behavior_dynamic_foraging_curricula.uncoupled_baiting",
               "version": "0.0.2-rc37",
               "commit_hash": "84120c95ce81dddcf403f535fa7740c2e48cf979",
               "container": null,
               "run_script": null,
               "language": "aind-behavior-curriculum",
               "language_version": null,
               "input_data": null,
               "parameters": null,
               "core_dependency": null
            }
         ],

@alexpiet

Copy link
Copy Markdown
Collaborator

Presumably the run script should be something like:

  • "run_script": "Aind.Behavior.DynamicForaging\src\main.bonsai",
    not
  • "run_script": "C:\Users\micah.woodard\Documents\GitHub\Aind.Behavior.DynamicForaging\src\main.bonsai",

Since we dont care about the installation path of the repo

@alexpiet alexpiet left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to fix the path for the run script, but otherwise looks good

@micahwoodard

Copy link
Copy Markdown
Collaborator Author

Presumably the run script should be something like:

  • "run_script": "Aind.Behavior.DynamicForaging\src\main.bonsai",
    not
  • "run_script": "C:\Users\micah.woodard\Documents\GitHub\Aind.Behavior.DynamicForaging\src\main.bonsai",

Since we dont care about the installation path of the repo

@alexpiet I'm using tools and patterns from vr foraging that require the full path. I'm inclined to keep it as is to stay aligned

@alexpiet

Copy link
Copy Markdown
Collaborator

Presumably the run script should be something like:

  • "run_script": "Aind.Behavior.DynamicForaging\src\main.bonsai",
    not
  • "run_script": "C:\Users\micah.woodard\Documents\GitHub\Aind.Behavior.DynamicForaging\src\main.bonsai",

Since we dont care about the installation path of the repo

@alexpiet I'm using tools and patterns from vr foraging that require the full path. I'm inclined to keep it as is to stay aligned

Sounds good. feel free to merge

@micahwoodard
micahwoodard merged commit b90e613 into main Sep 30, 2026
4 checks passed
@micahwoodard
micahwoodard deleted the fix-workspace-metadata-211-216 branch October 6, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants