Repository navigation
Fix reward unit and code version in mapper - #200
Merged
Merged
Conversation
Collaborator
|
Presumably the run script should be something like:
Since we dont care about the installation path of the repo |
alexpiet
approved these changes
Sep 29, 2026
alexpiet
left a comment
Collaborator
There was a problem hiding this comment.
It would be nice to fix the path for the run script, but otherwise looks good
Collaborator
Author
@alexpiet I'm using tools and patterns from vr foraging that require the full path. I'm inclined to keep it as is to stay aligned |
Collaborator
Sounds good. feel free to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix reward unit and code version in mapper.
Rewards are now measured in ul like legacy system
code is versioned better and tried to be less confusing. The results are below.
Per @rachelstephlee comments:
bonsai, acquisition, and curriculum code are all contained in the Aind.Behavior.DynamicForaging code base. The curriculum is a sub package and is version independently. Bonsai version is also versioned independently
It doesn't seem like the branch name is a part of the Code object