Repository navigation
Implement retry logic for valve duration message - #203
Merged
Merged
Conversation
Collaborator
|
@bruno-f-cruz this makes sense to me and I tested on 3c and didn't see any issues. I wasn't able to trigger the request/response qc error the three test sessions i ran though so |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a retry logic in case one of the valves is not correctly set.
This is a known, very rare issue with the behavior board wherein, if two messages are sent back-to-back in rare instances, the second one gets lost. This PR attempts to circumvent this issue by ensuring the reply is acknowledged, and if not, it retries with a new message. If the same attempt fails 3 times, an error will be raised, as this is likely a different issue. We are planning some changes to the bonsai package to mitigate this hardware issue, but in the meantime, this is likely a good option we have to balance performance with reliability.
@micahwoodard I did not get a chance to test it, so make sure this makes sense to you and give it a test at the rigs to see if it works, especially in the PC that is giving you the most issues.