Repository navigation
Visualizer fixes - #211
Open
NeuroThom wants to merge 5 commits into
Open
Visualizer fixes#211NeuroThom wants to merge 5 commits into
NeuroThom wants to merge 5 commits into
Conversation
The generator inherited the protocol's docstring-only get_metrics, which returns None and becomes a null TrialMetrics in Bonsai. Return TrialMetrics() and add a test. Closes AllenNeuralDynamics#206.
FilterNotNull ran on the metadata tuple before StageName was selected, and the Experimenter branch had no guard. Move the include after the selector and add one before the experimenter Count check. Closes AllenNeuralDynamics#205.
The Keep Open loops stop on a 3 min timer and report completion to the toggle buttons the same way the drain loops do. Closes AllenNeuralDynamics#140.
Each drain iteration publishes the time left from the repeat index, period and count; the Cancel labels display it. Closes AllenNeuralDynamics#209.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #205, closes #206, closes #210, closes #140, closes #209.
Fixes
Return empty metrics from integration generator #206
IntegrationTestTrialGeneratorinherited subclasses from theITrialGeneratordirectly, which only has a stub for get_metrics(), returningNone.TrialMetricswas therefore null andVisualizers.bonsaithrows. Addedget_metricsmethod to the generator, returningTrialMetrics()(biasNone). Unit test added.Guard null stage name and experimenter fields #205
In
MetadataVisualizer.bonsaitheFilterNotNullinclude on the stage name branch sat before splitting the tuple, which is never null. The experimenter field had no guard and throws atCountif anexperimenter: nullwere to pass. The null check now sits after the stage name selector and before the experimenter count.Open the visualizer window maximized #210
Changed
WindowStatetoMaximized.Close manually opened valves after 3 minutes #140
Added 3min
Timer, closing the valve after this time. NewKeepLeftOpenComplete/KeepRightOpenCompletesubjects carry that signal toPreSessionVisualizer.bonsaito reset theToggledstate of the Keep Open buttons and re-enable the Both button. Same strategy the drain buttons use.Show remaining drain time on the drain buttons #209
Computed time remaining from the
ElementIndexof theRepeatCountloop, the per-pulse period (RewardToTimeplus the 0.12 s of timer and delay overhead) and the pulse count. Value is shown in the button label, e.g.Cancel Drain Left (42 s).To check on the rig