Repository navigation
Fix rollout lifecycle, recovery, and validation - #12
Merged
Merged
Conversation
Manually port Dimweaker's seven fixes from fix/rollout-lifecycle-and-validation-20261030 onto main at 230b171. The source history has no common ancestor with main. Join real executor Tasks before closing runtime resources; retain durable group outcomes across restarts without replaying interrupted Runners; hold an OS lock on the service run directory. Keep log failures from blocking Web recovery, normalize target paths lexically, and raise the native example context budget to 32768. Require complete serving text/token agreement and bind every loaded slot to the requested sampling digest. Include the necessary numeric sampling canonicalization and cleanup admission checks for Docker and Sandbox, while preserving main's embedded path and optional math distillation. Source commits: 673659b, 6e2e7f9, a8f7e1d, 03caa72, 64b92e2, f08e6ba, 9814460 (source base ebb1efc). Validation: 350 CPU tests passed, 8 optional tests skipped. Example smoke, training dry run, shell/JavaScript syntax and public-tree audit passed. Changed Python files pass Ruff; main has five existing E402 findings in tests/test_consistency_torch.py. No live training acceptance is claimed. Co-authored-by: Dimweaker <443668214@qq.com>
Shield the group gather so run_group owns cancellation propagation. Without this, cancelling the parent first cancels every slot through gather, then a faster slot triggers another cancellation that interrupts a slower sibling's asynchronous finally block. Cancel each child once and wait for the original gather and all slots before allowing service shutdown to close the runtime. Add a regression that uses the real run_group with two slots of different cleanup speeds. Validation: the new regression fails before this fix and passes after it; the full CPU suite passes with 351 tests and 8 optional skips.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
将原作者 Dimweaker 的 7 个commit 适配到当前 main。