agents: implement essential skills - #290
Merged
Merged
Conversation
Translate `.vscode` configurations with corresponding `.zed` files: - Add `.zed/tasks.json` defining build tasks (`Build all` and `make clean`) with automatic saving of modified buffers before builds. - Add `.zed/debug.json` with launch profiles for f3brew, f3probe, f3write, and f3read using the GDB adapter, including inline build steps to ensure directory "a" exists. - Copy `gdb-sudo.sh` to `.zed/gdb-sudo.sh` for elevated debugging.
Migrate the F3 coding style from the Antigravity IDE v1.0 rule format in .agents/rules/coding-style.md to an agent skill located in .agents/skills/coding-style/SKILL.md.
Define conventions and guidelines for generating Git commit messages in F3 based on repository history and standards established across AltraMayor projects. This skill provides agents with rules for subsystem prefixes, subject line formatting, referencing functions with (), noting manual sections for system calls and library functions, and formatting issue closures.
The coding style rule previously stated that opening braces should always be on the same line, including for function definitions. However, throughout the entire repository, function definitions place the opening brace on a new line at column 0, following classic K&R and Linux kernel style. Update the braces rule to distinguish control statements and struct definitions from function definitions.
Under -std=c17, GCC's -pedantic flag no longer warns about mixed declarations and code because C99 and later standards permit them. Add -Wdeclaration-after-statement to CFLAGS in Makefile to enforce the coding style rule that variables must be declared at the beginning of their scope. Address this and other code style violations: 1. In f3write.c and f3read.c, move variable declarations to the beginning of block scopes to satisfy -Wdeclaration-after-statement. 2. In f3fix.c, drop the space before the opening parenthesis of main(). 3. In libutils.h, remove the // comment within the documentation block comment and fix a typo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements two essential skills: coding-style to preserve the style of the codebase, and commit-message to reduce the effort required to write useful commit messages. The coding-style skill is a conversion of the
agents/rules, an early skill format, whereas the commit-message skill is based on a successful experience in another project.This pull request also adds project settings for Zed. These settings are based on the same settings for VS Code.