os: add support for windows (2/2) - #2
Merged
Merged
Conversation
AmyJeanes
force-pushed
the
windows-ci
branch
from
September 7, 2026 18:49
3edec91 to
06c9702
Compare
The standalone build picks the mingw tool with clang (the default tool picks MSVC), links libc++ statically so the binaries run outside the MSYS2 shell, and links mman-win32 and winsock for mmap and visionipc's sockets; the extension modules link against the interpreter's import library. setup.py copies the .pyd the cython tool names. setup.sh pins uv to a native CPython (the MSYS2 toolchain's own python comes first on PATH and its wheels are incompatible) and activates the venv from Scripts/; test.sh's install test uses the same layout. tests.yml gains a windows-latest entry running in the CLANG64 shell from setup-msys2, with a five-minute budget for ./test.sh on the 4-core runner. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016AgqYZYWLpwE2T5vS3nVEt
AmyJeanes
force-pushed
the
windows-ci
branch
from
September 7, 2026 20:11
06c9702 to
c7e8369
Compare
This was referenced Sep 7, 2026
AmyJeanes
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the msgq Windows backend PR, commaai#709: after that change lets openpilot build and run msgq on Windows, this one makes msgq itself build and test there, with a
windows-latestCI entry to keep it that way.Why this lives on my fork for now. It is stacked on the Windows backend branch, so it targets that branch here and the diff shows only the follow-up. It cannot go upstream until that PR has merged. Nothing here needs the comma-deps Windows wheels: msgq's dev dependencies are all on PyPI for win_amd64 (the
cppcheckwheel ships a Windows binary), so there is no fork-only commit and this can be recreated against comma as soon as the base merges.What changes
commonlist now chooses per platform,rton Linux as before), and the Cython modules linked against the interpreter's import library..pydthe cython tool names on Windows.Scripts/; test.sh's install test uses the same layout.windows-latestentry running the same./test.shfrom an MSYS2 CLANG64 shell (only clang is installed on top of the runner's MSYS2), with a five-minute budget where the others keep one. Only that entry names its shell; the others keepbash -e {0}, GitHub's implicit default.Testing
./test.shon Windows: build, ruff, ty, codespell, cppcheck, cpplint, the C++ runner (14/14), the unit tests (29) and the install test (3) pass, 13 s on a workstation.The changes in this PR were generated by Claude Fable 5.1 but were human reviewed and fully tested end to end both locally and in CI.