Restore clarification output safety gates - #5
Closed
AndreasInk wants to merge 1 commit into
Closed
Conversation
Owner
Author
|
Closing for now, too much complexity for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The clarification simplification merged in PR #2 removed deterministic grounding and sensitive-output checks. This was not a demonstrated exploit—the model is on-device and tool-less—but it was a product-trust regression because arbitrary nonempty model output could reach tester-facing UI and notification text.
Returning
nilis lossless: BetaFeedbackKit keeps the tester's original response and simply skips the optional follow-up.Verification
swift buildswift test— 61 tests passed1.0and question quality3.6875(minimum3.0)git diff --checkRegression cases
The output gate rejects, among others:
Which slider disappeared?when neither detail came from the testerWhat happened after you paid for the subscription?when that action was not supplied123and482913, even when present in the input