[RSLiu1996]

Fix Menu Small Screens

all.js.erb had syntax errors and spacing issues causing it not to load. When fixed all.js is loaded in the browser and the menu functions as expected.

Fixes Issues

• Closes XAMPP dashboard menu becomes hamburger icon on the top right in a mobile browser and does not drop down when tapped #47

[juamedgod]

I believe the spacing in the file is ok but the issues are caused because the .ready statement should be out of the is_xampp condition:

--- a/source-common/javascripts/all.js.erb
+++ b/source-common/javascripts/all.js.erb
@@ -3,8 +3,9 @@

 $(document).foundation();

-<% unless is_xampp? %>
+
 $(document).ready(function() {
+<% unless is_xampp? %>
   // Load latest forum posts
   var discussions = $('#discussions'), limit = <%= settings.forum_post_count %>;
   if ( $('#discussions').length !== 0 ) {

That solved the issue for me. In addition to that, the isLinux check missing the parenthesis. The change in isLinux64 and isRetina declarations is also ok.

[RSLiu1996]

You are correct. I did not see the $(document).ready(function() inside the is_xampp block, so my solution was to remove the }); on line 73 since it did not have a matching ({ which impacted the spacing. I will go ahead and apply your change to this PR and test it. Due to scoping issues the changes in isLinux64 and isRetina are required for the javascript to work.

[RSLiu1996]

The commit has been updated. Thanks for the last review let me know if anything should be changed.