fix(providers): treat an empty OpenAI api_key as unset - #41
Merged
Merged
Conversation
The OpenAI SDK falls back to OPENAI_API_KEY only when api_key is None; an empty string raises "Missing credentials" even with the variable set. A host config read before the environment is populated legitimately holds "", so both OpenAI clients now pass api_key or None. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This was referenced Sep 25, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenAIClientandOpenAIResponsesClientpassedapi_keystraight toAsyncOpenAI. The SDK only consultsOPENAI_API_KEYwhenapi_key is None; an empty string raisesOpenAIError: Missing credentialseven when the env var is set (verified on openai 3.7.0). Host configs read before the environment is populated legitimately hold"", so both clients now passapi_key or None.Found while migrating FrontierAgent onto AgentCore 0.11.1 — its forked client already did
api_key or None, and it currently carries a subclass just to keep that behaviour (ApodexAI/FrontierAgent#50).Changelog entry (suggested, under Fixed)
OpenAIClient/OpenAIResponsesClient: an emptyapi_keynow falls back toOPENAI_API_KEYlikeNone, instead of raising "Missing credentials".Test plan
tests/test_openai_empty_api_key.py(fails without the fix, passes with it)ruff,pyright agent_core, fullpytest -q🤖 Generated with Claude Code