fix(observers): make TaskBoardObserver critical so its reminder lands - #42
Merged
Merged
Conversation
The observer's only output is an Intervention, and notify_observers only collects return values from critical observers. As non-critical it ran in the background and the board reminder never reached the next turn; every host had to subclass it back to critical. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This was referenced Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TaskBoardObserver's only output is theInterventionit returns fromon_turn_end.notify_observersonly collects return values from critical observers; non-critical ones run as background tasks whose results are discarded. Withcritical = False, the board reminder was silently dropped and never reached the next turn.Both hosts already work around it by subclassing back to
critical = True(ApodexHarness, and FrontierAgent in ApodexAI/FrontierAgent#50, whose test suite pinscritical is True). This makes the shared default correct.Changelog entry (suggested, under Fixed)
TaskBoardObserveris nowcritical, so its board reminder is actually injected into the next turn. Hosts that subclassed it only to flipcriticalcan drop the subclass.Test plan
tests/test_task_board_observer.py: the reminder is collected as anInterventionbynotify_observers(fails before, passes after)ruff,pyright agent_core, fullpytest -q🤖 Generated with Claude Code
Release workflow
Uses the shared centralized-release workflow in #44. This PR keeps the current package version and contributes its own independent
changes/fragment. Version, lockfile and changelog aggregation happen in a later release PR. #40, #42 and #43 were tested in all six merge orders without conflicts.