Skip to content

Update Node dependencies. - #655

Merged
jakubnowicki merged 8 commits into
mainfrom
update-node-dependencies
Jun 10, 2026
Merged

jakubnowicki merged 8 commits into
mainfrom
update-node-dependencies

Conversation

@jakubnowicki

@jakubnowicki jakubnowicki commented Jun 8, 2026 •

Copy link
Copy Markdown
Member

Update Node dependencies

Refreshes the Node.js toolchain shipped in inst/templates/node/ to clear security vulnerabilities, and hardens the e2e tests that guard it.

Changes

  • Updated Node dependencies (within compatible majors) and regenerated the lockfile, clearing all npm audit advisories except 4 dev-only moderates in the Cypress chain (cleared only by a Cypress 15 major bump).
  • Held stylelint at v14 (v15+ drops stylistic rules — see Upgrade stylelint #521) and eslint at v8 (v9 would require replacing the unmaintained airbnb config).
  • Bumped the minimum supported Node.js to 20 (a transitive dep now requires it); updated the e2e workflow, tutorial prerequisites, and NEWS.
  • Strengthened the Node-tool e2e tests (build_js/build_sass/lint_js/lint_sass/format_js/format_sass) to exercise real toolchain capabilities (JSX & modern-JS transpilation, Sass @use/mixins/math, lint-rule enforcement) so future dependency bumps are actually validated. Fixtures now clean up on failure.
  • Fixed a flaky e2e failure on ubuntu-24.04 (devel) by freeing port 3333 before the second test_e2e() run (a Shiny server orphaned by start-server-and-test's SIGINT).

Definition of Done

  • The change is thoroughly documented.
  • The CI passes (R CMD check, linter, unit tests, spelling).
  • Any generated files have been updated (e.g. .Rd files with roxygen2::roxygenise())

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Rhino Node.js template dependency versions (used for generated apps) and records the change in the package changelog, along with a routine development version bump.

Changes:

  • Updated Node template devDependencies versions in inst/templates/node/package.json.
  • Added a NEWS entry noting the Node dependency updates for security scanning findings.
  • Bumped the R package development version in DESCRIPTION.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
NEWS.md Documents the Node dependency update in the development changelog.
inst/templates/node/package.json Updates Node template devDependency version ranges used by generated Rhino apps.
DESCRIPTION Increments the development version to reflect the change.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.

Comment thread tests/e2e/test-lint-js.R Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.

Comment thread tests/e2e/test-build-js.R Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.

Comment thread tests/e2e/test-build-js.R Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.

Comment thread inst/templates/node/package.json Resolved
Comment thread tests/e2e/test-build-js.R Resolved
Comment thread tests/e2e/test-build-sass.R Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 14 changed files in this pull request and generated 4 comments.

Comment thread tests/e2e/test-lint-js.R Resolved
Comment thread tests/e2e/test-lint-sass.R Resolved
Comment thread tests/e2e/test-format-js.R Resolved
Comment thread tests/e2e/test-format-sass.R Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 14 changed files in this pull request and generated 1 comment.

@jakubnowicki jakubnowicki changed the title chore: Update Node dependencies. Update Node dependencies. Jun 9, 2026
@jakubnowicki
jakubnowicki requested a review from mdubel June 9, 2026 13:54
@jakubnowicki
jakubnowicki marked this pull request as ready for review June 9, 2026 13:55
@jakubnowicki
jakubnowicki merged commit 296eae4 into main Jun 10, 2026
15 of 16 checks passed
@jakubnowicki
jakubnowicki deleted the update-node-dependencies branch June 10, 2026 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants