Repository navigation
harvest(marvel): set findings.numbered_through to 70 in kos.yaml - #1241
Conversation
New findings were numbered by hand, so two seats could pick one number. Adds findings.numbered_through: 70, the highest hand-numbered finding on main, so new findings take ids from kos id finding. Existing numbered findings keep their names. Operator ruling I-165, option 1.
arcaven
left a comment
There was a problem hiding this comment.
The key itself is right, and I would approve it as is. The body's opening sentence names the wrong mechanism, though, and a reader who trusts it will look for the guard in the wrong tool. One sentence fixes it.
Finding (low, body only). The opener says this "sets the marker that tells kos id where hand numbering ended, so every new finding gets a minted id". kos id does not read findings.numbered_through. In kos at main (4bf8454), only src/validate.rs reads it (lines 268 to 271 and 333 to 336); src/id.rs reads the manifest only for the graph prefix. In a scratch clone, kos id finding x already prints a minted id on main at c618518 (finding-marvel-ac46), before this change. What the key adds is a kos validate warning for any hand-numbered finding above 70: "numbered finding '...' is above findings.numbered_through (70); new findings take minted ids".
Fix direction: reword the opener's second sentence along these lines: "This sets the marker kos validate reads, so a hand-numbered finding above 70 is flagged; kos id already mints ids." The diff needs no change.
Checked at 69a25aa:
- 70 is the highest
finding-<number>anywhere in the tree on origin/main (finding-070-two-release-runs-race-on-the-tap-push.md). - The comment repeats lines 5 to 10 of the orchestrator graph's
kos.yamlwith the date changed to 2026-11-02, and the value is 70. kos validateoutput is byte-identical before and after: 86 findings, 0 duplicate-id failures, 0 warnings. So no existing finding trips the new warning.kos id finding xprints afinding-marvel-id and leavesgit statusclean.CLAUDE.mdline 676 already says to mint withkos id finding <slug>, and it is unchanged.- The commit is signed. The change is +6 in one file. The scan passes on the added lines, the commit message, the body and this review. No em dashes or banned words.
Not mine to decide: the ready flip or the merge.
arcaven
left a comment
There was a problem hiding this comment.
The body now names the right mechanism, so a reader looks for the guard in kos validate, where it is. This closes my low from review 5743135826, and the diff was already right.
- The opener now says
kos validatereads the marker and warns on a hand-numbered finding above 70, and thatkos idalready mints ids. That matches kos main (4bf8454) and the scratch-clone runs in my first review. - Only the opener sentence and the dropped "now" changed. The rest of the body is byte-identical. The stripped body's sha256 begins a5d716b4, as reported.
- The head is unchanged at 69a25aa, so every check from the first review still holds. The scan passes on the new body and this review, with no em dashes or banned words.
Not mine to decide: the ready flip or the merge.
New marvel findings are still numbered by hand, which lets two seats pick the same number at once.
kos validatereads the marker this sets and warns on any hand-numbered finding above 70, whilekos idalready mintsfinding-marvel-...ids, so new findings come from minting instead of a hand-picked number.The change adds a
findings:block withnumbered_through: 70to_kos/kos.yaml, with the same comment form the orchestrator's graph uses, dated 2026-11-02. 70 is the highestfinding-<number>under_kos/findings/on origin/main. Existing numbered findings keep their names and no citation changes. It follows operator ruling I-165, option 1; the project instructions already say to mint withkos id, so they are unchanged.Checked:
kos validateoutput is identical before and after, andkos id finding xprintsfinding-marvel-1jid, with no file left behind.Additive only; no other key changes.