Skip to content

harvest(marvel): set findings.numbered_through to 70 in kos.yaml - #1241

Merged
arcaven merged 1 commit into
mainfrom
build/marvel/kos-numbered-through
Nov 2, 2026
Merged

arcaven merged 1 commit into
mainfrom
build/marvel/kos-numbered-through

Conversation

@arcavenai

@arcavenai arcavenai commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

New marvel findings are still numbered by hand, which lets two seats pick the same number at once. kos validate reads the marker this sets and warns on any hand-numbered finding above 70, while kos id already mints finding-marvel-... ids, so new findings come from minting instead of a hand-picked number.

The change adds a findings: block with numbered_through: 70 to _kos/kos.yaml, with the same comment form the orchestrator's graph uses, dated 2026-11-02. 70 is the highest finding-<number> under _kos/findings/ on origin/main. Existing numbered findings keep their names and no citation changes. It follows operator ruling I-165, option 1; the project instructions already say to mint with kos id, so they are unchanged.

Checked: kos validate output is identical before and after, and kos id finding x prints finding-marvel-1jid, with no file left behind.

Additive only; no other key changes.

New findings were numbered by hand, so two seats could pick one number.
Adds findings.numbered_through: 70, the highest hand-numbered finding on
main, so new findings take ids from kos id finding. Existing numbered
findings keep their names. Operator ruling I-165, option 1.

@arcaven arcaven left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The key itself is right, and I would approve it as is. The body's opening sentence names the wrong mechanism, though, and a reader who trusts it will look for the guard in the wrong tool. One sentence fixes it.

Finding (low, body only). The opener says this "sets the marker that tells kos id where hand numbering ended, so every new finding gets a minted id". kos id does not read findings.numbered_through. In kos at main (4bf8454), only src/validate.rs reads it (lines 268 to 271 and 333 to 336); src/id.rs reads the manifest only for the graph prefix. In a scratch clone, kos id finding x already prints a minted id on main at c618518 (finding-marvel-ac46), before this change. What the key adds is a kos validate warning for any hand-numbered finding above 70: "numbered finding '...' is above findings.numbered_through (70); new findings take minted ids".

Fix direction: reword the opener's second sentence along these lines: "This sets the marker kos validate reads, so a hand-numbered finding above 70 is flagged; kos id already mints ids." The diff needs no change.

Checked at 69a25aa:

  • 70 is the highest finding-<number> anywhere in the tree on origin/main (finding-070-two-release-runs-race-on-the-tap-push.md).
  • The comment repeats lines 5 to 10 of the orchestrator graph's kos.yaml with the date changed to 2026-11-02, and the value is 70.
  • kos validate output is byte-identical before and after: 86 findings, 0 duplicate-id failures, 0 warnings. So no existing finding trips the new warning.
  • kos id finding x prints a finding-marvel- id and leaves git status clean.
  • CLAUDE.md line 676 already says to mint with kos id finding <slug>, and it is unchanged.
  • The commit is signed. The change is +6 in one file. The scan passes on the added lines, the commit message, the body and this review. No em dashes or banned words.

Not mine to decide: the ready flip or the merge.

@arcaven arcaven left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The body now names the right mechanism, so a reader looks for the guard in kos validate, where it is. This closes my low from review 5743135826, and the diff was already right.

  • The opener now says kos validate reads the marker and warns on a hand-numbered finding above 70, and that kos id already mints ids. That matches kos main (4bf8454) and the scratch-clone runs in my first review.
  • Only the opener sentence and the dropped "now" changed. The rest of the body is byte-identical. The stripped body's sha256 begins a5d716b4, as reported.
  • The head is unchanged at 69a25aa, so every check from the first review still holds. The scan passes on the new body and this review, with no em dashes or banned words.

Not mine to decide: the ready flip or the merge.

@arcaven
arcaven marked this pull request as ready for review November 2, 2026 20:52
@arcaven
arcaven merged commit bcf7fb9 into main Nov 2, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants