fix: close stdin for captured child processes - #73
Merged
Conversation
Captured targets inherited the caller's TTY as stdin while stdout/stderr were piped into the progress UI, so tools that prompt (e.g. pnpm's modules-purge confirm) hung with no visible prompt. Close stdin by default for captured execution; streaming targets still inherit the terminal. Fixes #72
- Docs named `aster run --stream`, which is not a flag on `aster run` — corrected to `aster <target> --stream`, the invocation that actually inherits the terminal. - Vestigial `null_stdin` bool / `with_null_stdin()` no-op — declined: keeping the documented call site is intentional; collapsing the flag is scope expansion. Constructor tests guard the default. Reviewers: grok-native, claude-cli, review-principles
The macOS suite failed three supervisor tests on port-bind timeouts while Ubuntu and the stdin hang tests passed. Those tests already contended for ephemeral ports when run beside other process tests; run the crate alone and single-threaded on macOS.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Captured target commands inherited the caller's TTY as stdin while stdout/stderr were piped into Aster's progress UI. Tools that prompt (for example pnpm's modules-purge confirm) then hung with no visible prompt. Closes stdin for captured execution by default. Streaming targets (
stream = true,aster <target> --stream) still inherit the terminal.Fixes #72
Verification
cargo fmt --all -- --checkcargo clippy --locked --all-targets --all-features -- -D warningsRUSTDOCFLAGS="-D warnings" cargo doc --locked --no-deps --all-featurescaptured_targets_do_not_hang_on_stdin_prompts(holds Aster's stdin pipe open so an inheritedreadwould hang)isatty(0)unit testscargo test --locked --all-targets --all-featuresotherwise passed here exceptdev_tls(configured_tls_routes_replace_upstream_localhost_open_urls_in_public_plan), which failed because ports 3100/3800/8443 were already bound on this machine.A captured target whose command is
read(or another prompt) should fail or return immediately instead of hanging behind the progress UI.aster <target> --streamshould still be interactive.Checklist