Skip to content

feat: tool-offer narrowing per-node opt-out and dynamic tool descriptions - #398

Closed
montionugera wants to merge 1 commit into
AreevAI:mainfrom
montionugera:feat/issue-396
Closed

montionugera wants to merge 1 commit into
AreevAI:mainfrom
montionugera:feat/issue-396

Conversation

@montionugera

Copy link
Copy Markdown

Closes #396

@montionugera
montionugera requested a review from a team as a code owner October 20, 2026 02:13
@sathish-mg

Copy link
Copy Markdown
Contributor

Thanks for taking this on, and sorry for the collision. The same feature landed on the 1.13.0 release branch about an hour before this PR was opened (d7f726d, "RUN: per-node tool-offer narrowing (llm.narrow) and dynamic tools described in the ask (#396)") and merged to main with #399, so #396 is already closed as completed and this branch now conflicts in all seven files.

What shipped, for comparison:

  • narrow lives inside the per-node llm block: llm.<node>.narrow: false or {"top_k": 1-254}. It is validated with the rest of that block in crates/areev-run/src/llmcfg.rs (a malformed value is RUN-E019), and true normalizes to absent so no manifest changes bytes.
  • The narrowing question reads a tools_from tool's description off the pinned DynamicTool already on the offer (OfferedTool.dynamic), first line only, rather than through a new field the driver would have to populate.
  • Docs: docs/run.md "Narrowing the tool offer" plus the llm block table, and the 1.13.0 CHANGELOG entry.

Nothing wrong with the approach here. It is the same shape, it just arrived after the maintainer's version had been written. Closing this one.

If the shipped version does not cover your case (you clearly hit this in practice), please open an issue with the plan shape and the tool list size and I will pick it up.

@sathish-mg sathish-mg closed this Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tool-offer narrowing: a per-node opt-out and the dynamic tools' descriptions

2 participants