Skip to content

iOS audit (1/3): 911 link, sign-in keyboard, Notes scroll, photo error banner - #30

Merged
Arluigi merged 8 commits into
mainfrom
ios-audit/quick-fixes
Sep 28, 2026
Merged

Arluigi merged 8 commits into
mainfrom
ios-audit/quick-fixes

Conversation

@Arluigi

@Arluigi Arluigi commented Sep 28, 2026

Copy link
Copy Markdown
Owner

First of three PRs from the 2026-09-28 Apple-design audit of the patient app (plan: docs/superpowers/plans/2026-09-28-ios-design-audit.md). Client-only; no API or schema change.

  • Urgent report: "call 911 now" gets a tappable tel:911 button; the details field takes focus once a category is picked.
  • Sign-in and recovery: Return moves between fields and submits; .password / .newPassword AutoFill; Show/Hide keeps focus; switching to Create account keeps the email; offline and wrong-credentials errors have their own sentences (Supabase returns invalid_credentials for unknown emails too, so nothing is disclosed).
  • Notes: opens at the newest note, scrolls to new ones (not on Load older), shows the outgoing note with a SENDING… stamp while it sends, pull-to-refresh, keyboard dismisses on scroll, each note reads as one VoiceOver element.
  • Photo error banner: now sits above the tab bar in each tab's safe-area inset instead of over it, is dismissable, and is announced once.
  • Small fixes: onboarding name field submits on Return; check-in "Back to review" when editing from the review list; sentence-case "Take photo" / "Choose from library"; adherence error at 13pt.
  • Docs: CLAUDE.md now states the real deployment target (iOS 18.5, built with Xcode 27).

Verification: 247/247 unit tests on the iPhone 17 / iOS 27 simulator. Spec+quality review and care-access-reviewer both run; the one Important finding (repeated VoiceOver announcement) is fixed. UI suite and on-device visual checks not run.

🤖 Generated with Claude Code

Arluigi and others added 8 commits September 28, 2026 17:46
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…otes load without animation

Pins the urgent details auto-focus and covers cancelling a message send mid-flight.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings September 28, 2026 23:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Arluigi
Arluigi merged commit 6057c53 into main Sep 28, 2026
10 checks passed
@Arluigi
Arluigi deleted the ios-audit/quick-fixes branch September 28, 2026 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants