Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ Four indexers are constructed in `index.ts`: main (`getAllProjects`), Engine (`g
### Data

- **Hasura** (public): `https://data.artblocks.io/v1/graphql` — hardcoded in `queryGraphQL.ts` / `codegen.ts`. Optional `HASURA_GRAPHQL_ADMIN_SECRET`.
- **One GraphQL client** — there is **no** separate Arbitrum Hasura client (older docs were wrong).
- **One GraphQL client** — there is **no** separate Arbitrum Hasura client (older docs were wrong). urql uses `dedupExchange` + `fetchExchange` only (no document cache) so unique queries do not accumulate in a long-running process.
- **Supabase**: trivia scores + Twitter OAuth/state only (`src/Data/supabase.ts`).
- Queries live in `src/Data/graphql/*.graphql`; wrappers in `src/Data/queryGraphQL.ts`.

Expand Down Expand Up @@ -135,6 +135,8 @@ Token/mint data can include chain IDs (Ethereum, Arbitrum, Base). **OpenSea stre
8. **Issue templates** under `.github/ISSUE_TEMPLATE/` map 1:1 to maintenance tasks — follow those file touch lists.
9. **No health endpoint** — hosting liveness is process + logs. `/update` is a stub.
10. **CODEOWNERS**: `@ArtBlocks/Eng-Approvers-Product`. Do not assign personal Discord handles from the old README.
11. **OpenSea stream reconnect must `disconnect()` the previous Phoenix client** before constructing a new one. Do not reset `reconnectAttempts` until a stream event confirms the socket is live. Keep wildcard `*` subscriptions (OpenSea topics are collection slugs, not contracts; ArtBot filters by contract address).
12. **Do not add urql `cacheExchange`** — this process is long-lived; the document cache never expires. App-level caches (project dicts, wallet TTL) are the right layer.

## Common tasks

Expand Down
5 changes: 4 additions & 1 deletion src/Data/queryGraphQL.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as dotenv from 'dotenv'
import { createClient } from 'urql/core'
import { createClient, dedupExchange, fetchExchange } from 'urql/core'
import * as fs from 'fs'
import * as path from 'path'
import { sanitizeTwitterHandle } from '../Utils/twitterUtils'
Expand Down Expand Up @@ -79,6 +79,9 @@ const client = createClient({
})
: undefined,
requestPolicy: 'network-only',
// Long-running process: skip cacheExchange so unique queries do not accumulate forever.
// Keep dedupExchange so in-flight identical queries still share one request.
exchanges: [dedupExchange, fetchExchange],
})

const maxProjectsPerQuery = 1000
Expand Down
109 changes: 79 additions & 30 deletions src/index.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import * as dotenv from 'dotenv'
dotenv.config()
import { Client, Events, GatewayIntentBits, Status } from 'discord.js'
import { Client, Events, GatewayIntentBits, Options, Status, User } from 'discord.js'
import * as dns from 'dns'
import * as https from 'https'
const express = require('express')
Expand Down Expand Up @@ -218,6 +218,19 @@ export const discordClient = new Client({
GatewayIntentBits.GuildMessages,
GatewayIntentBits.MessageContent,
],
// Sweep stale messages/users; leave channel and emoji caches alone
// (channel lookups and the `gmsquig` gm-reaction depend on them).
sweepers: {
...Options.DefaultSweeperSettings,
messages: {
interval: 3600,
lifetime: 1800,
},
users: {
interval: 3600,
filter: () => (user: User) => user.id !== user.client.user?.id,
},
},
})

logger.info('Discord client created')
Expand Down Expand Up @@ -515,7 +528,11 @@ export const mintBot = new MintBot(discordClient, abTwitterBot)
* 3. **Connection Monitoring**: Health checks every minute with connection stats
* 4. **Graceful Degradation**: Falls back to API polling when max reconnections reached
* 5. **Configuration**: Environment variables for customizing reconnection behavior
* 6. **Resource Management**: Proper cleanup of timers and connections on shutdown
* 6. **Resource Management**: Disconnect the previous Phoenix client before opening a new one
* (creating a new client without disconnect leaked sockets and `*` firehose listeners)
*
* Subscriptions stay on `*` (all collections) and are filtered by contract address. OpenSea
* topics are collection slugs, which do not map 1:1 to Art Blocks/Engine/Studio contracts.
*
* Debug access: `getOpenSeaConnectionStats()` in Node.js console
*/
Expand Down Expand Up @@ -547,9 +564,11 @@ const CONNECTION_HEALTH_CHECK_INTERVAL = parseInt(
process.env.OPENSEA_HEALTH_CHECK_INTERVAL || '60000'
) // 1 minute

let openseaStreamClient: OpenSeaStreamClient
let openseaStreamClient: OpenSeaStreamClient | undefined
let reconnectTimeout: NodeJS.Timeout | null = null
let healthCheckInterval: NodeJS.Timeout | null = null
/** Bumped on every replace/shutdown so stale clients cannot schedule reconnects. */
let streamClientGeneration = 0

// Calculate exponential backoff delay with jitter
function getReconnectDelay(attemptNumber: number): number {
Expand All @@ -562,9 +581,42 @@ function getReconnectDelay(attemptNumber: number): number {
return Math.max(1000, exponentialDelay + jitter)
}

function disconnectOpenSeaStreamClient() {
const client = openseaStreamClient
if (!client) {
return
}
openseaStreamClient = undefined
try {
client.disconnect(() => {
logger.info('OpenSea WebSocket disconnected')
})
} catch (error) {
logger.error({ err: error }, 'Error disconnecting OpenSea WebSocket')
}
}

/** Confirm the socket is live; only then reset the reconnect budget. */
function markOpenSeaConnected() {
if (!connectionState.isConnected) {
logger.info(
{ reconnectAttempts: connectionState.reconnectAttempts },
'OpenSea WebSocket connection confirmed via stream event'
)
}
connectionState.isConnected = true
connectionState.reconnectAttempts = 0
connectionState.lastConnectTime = Date.now()
}

// Initialize OpenSea Stream Client with error handling
function initializeOpenSeaStreamClient(): OpenSeaStreamClient {
logger.info('Initializing OpenSea Stream Client')
// Invalidate the previous client first so its onError cannot reconnect.
streamClientGeneration += 1
const generation = streamClientGeneration
disconnectOpenSeaStreamClient()

logger.info({ generation }, 'Initializing OpenSea Stream Client')

const client = new OpenSeaStreamClient({
token: process.env.OPENSEA_API_KEY ?? '',
Expand All @@ -573,6 +625,9 @@ function initializeOpenSeaStreamClient(): OpenSeaStreamClient {
sessionStorage: LocalStorage,
},
onError: (error: unknown) => {
if (generation !== streamClientGeneration) {
return
}
logger.error({ err: error }, 'OpenSea Stream Client error')
connectionState.lastError = error as Error
connectionState.isConnected = false
Expand All @@ -598,12 +653,9 @@ function initializeOpenSeaStreamClient(): OpenSeaStreamClient {
},
})

// The OpenSeaStreamClient handles connection internally using Phoenix channels
// We'll rely on the onError callback and add additional monitoring
// Do not mark connected or reset reconnectAttempts here — Phoenix may still
// be connecting. Confirmation happens when a stream event arrives.
logger.info('OpenSea Stream Client initialized with error handling')
connectionState.isConnected = true
connectionState.reconnectAttempts = 0
connectionState.lastConnectTime = Date.now()

// Start health check monitoring
if (!healthCheckInterval) {
Expand Down Expand Up @@ -638,9 +690,8 @@ function scheduleReconnection() {
'Attempting OpenSea WebSocket reconnection'
)
try {
// Reinitialize the stream client
openseaStreamClient = initializeOpenSeaStreamClient()
setupStreamEventHandlers()
setupStreamEventHandlers(openseaStreamClient)
} catch (error) {
logger.error({ err: error }, 'Failed to reinitialize OpenSea Stream Client')
scheduleReconnection()
Expand All @@ -657,7 +708,11 @@ function startHealthCheckMonitoring() {
: Infinity

if (!connectionState.isConnected) {
logger.warn('OpenSea WebSocket health check: Connection lost, reconnection should be in progress')
if (connectionState.reconnectAttempts >= MAX_RECONNECT_ATTEMPTS) {
logger.warn('OpenSea WebSocket health check: max reconnects reached, relying on API polling')
} else {
logger.warn('OpenSea WebSocket health check: Connection lost, reconnection should be in progress')
}
} else if (timeSinceLastConnect > 600000) {
// 10 minutes
logger.info(
Expand All @@ -677,12 +732,11 @@ function startHealthCheckMonitoring() {
}

// Setup stream event handlers
function setupStreamEventHandlers() {
// Note: OpenSeaStreamClient doesn't expose removeAllListeners
// Duplicate listeners are handled internally by the Phoenix channels

// Your existing event handlers with additional error handling
openseaStreamClient.onItemListed('*', async (event) => {
function setupStreamEventHandlers(client: OpenSeaStreamClient) {
// Wildcard `*` is required: OpenSea topics are collection slugs, not contract
// addresses, and Art Blocks/Engine/Studio inventory is tracked by contract.
client.onItemListed('*', async (event) => {
markOpenSeaConnected()
if (!PRODUCTION_MODE) {
return
}
Expand Down Expand Up @@ -710,7 +764,8 @@ function setupStreamEventHandlers() {
}
})

openseaStreamClient.onItemSold('*', async (event) => {
client.onItemSold('*', async (event) => {
markOpenSeaConnected()
if (!PRODUCTION_MODE) {
return
}
Expand Down Expand Up @@ -786,7 +841,7 @@ if (typeof global !== 'undefined') {
// Initialize the stream client
logger.info('Starting OpenSea WebSocket Stream integration')
openseaStreamClient = initializeOpenSeaStreamClient()
setupStreamEventHandlers()
setupStreamEventHandlers(openseaStreamClient)

logger.info(
{ MAX_RECONNECT_ATTEMPTS, INITIAL_RECONNECT_DELAY, MAX_RECONNECT_DELAY },
Expand Down Expand Up @@ -874,6 +929,9 @@ if (PRODUCTION_MODE) {
function cleanupOpenSeaConnections() {
logger.info('Cleaning up OpenSea WebSocket connections')

// Invalidate the current client so in-flight onError cannot reconnect
streamClientGeneration += 1

// Clear reconnection timeout
if (reconnectTimeout) {
clearTimeout(reconnectTimeout)
Expand All @@ -886,16 +944,7 @@ function cleanupOpenSeaConnections() {
healthCheckInterval = null
}

// Disconnect OpenSea stream client gracefully
if (openseaStreamClient) {
try {
openseaStreamClient.disconnect(() => {
logger.info('OpenSea WebSocket disconnected successfully')
})
} catch (error) {
logger.error({ err: error }, 'Error disconnecting OpenSea WebSocket')
}
}
disconnectOpenSeaStreamClient()

// Reset connection state
connectionState.isConnected = false
Expand Down
Loading