Generic TipTopPSF class for generating then caching PSFs from the UniVie tiptop server - #992
Draft
astronomyk wants to merge 2 commits into
Draft
Generic TipTopPSF class for generating then caching PSFs from the UniVie tiptop server#992astronomyk wants to merge 2 commits into
astronomyk wants to merge 2 commits into
Conversation
New PSF effect that queries the TipTop AO simulator (via tiptop_ipy, default server: University of Vienna) for an on-axis AO PSF and caches the result on disk. Each unique configuration (instrument ini + wavelength + grid) costs exactly one server call, ever. With wave_dict + filter_name (e.g. '!OBS.filter_name'), an imager generates one PSF per filter band, at most 1024x1024 pixels. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…emplate
- filter_name alone now resolves the effective wavelength through the
SVO filter service: generic band names (V, J, Ks, ...) via
FILTER_DEFAULTS, or fully qualified SVO ids (Paranal/HAWKI.Ks).
wavelength accepts a filter-name string too. wave_dict remains the
explicit override for instrument-specific filter names.
- overrides can now remove keys ({key: null}) and whole sections
({section: null}) from the TipTop config, needed e.g. for MORFEO.
- Server-side failures are re-raised with the offending configuration
and a hint about grid limits.
- Docstring examples for METIS SCAO, MICADO SCAO and MORFEO MCAO, all
validated live against the Vienna server:
METIS Lp 3.79um @ 5.47mas: Strehl 0.87 (finer grids are rejected
server-side; detector scale still oversamples lambda/2D)
MICADO Ks 2.19um @ 2mas: Strehl 0.66
MORFEO Ks 2.19um @ 2mas: Strehl 0.65 (needs glFocusOnNGS: False
+ Focus sections removed; stock template crashes TIPTOP 1.4.0)
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #992 +/- ##
===========================================
- Coverage 75.17% 29.15% -46.03%
===========================================
Files 70 68 -2
Lines 9024 9062 +38
===========================================
- Hits 6784 2642 -4142
- Misses 2240 6420 +4180 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Obviously geCluadet, but it seems to do what it claims. I've read every line of code and nothing jumped out as obviously wrong. According to the report, it stress tested also the METIS and MICADO/MORFEO cases, and found a work-around for the bug with the MORFEO ini files (doesn't like the Focuser keywords...)
The result is a new FieldConstantPSF effect that calls the TIPTOP server, and saves the file to disk for later re-use. This doubles the caching, as the tiptop-on-zeus server also caches any PSF it generates. An example of the IRDB effect yamle ntry is:
I plan to play around with it in a notebook today and then let you know if I find any obvious bugs