Repository navigation
feat(components,core): make opacity for dotfiles configurable - #108
Merged
Merged
Conversation
…ile opacity Adds a new setting and preference toggle to make hidden files and folders opaque—similar to regular files—instead of rendering them with reduced opacity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
This PR adds a new
opaqueHiddenoption underpreferences(along with a corresponding preference toggle in settings) to make hidden files and folders opaque, rather than rendering them with reduced opacity. WithopaqueHiddenset totrue, dotfiles are displayed with the same opacity to regular files. This option defaults tofalse, so existing behavior is preserved.Why
I've previously used Nautilus, which only changes the item's icon when it's hidden (rather than the entire row), leaving the text the same opacity as regular, non-hidden items. I work with hidden files and folders about as often as I do with regular files, so I don't really get any benefit from a visual distinction between them. The lowered opacity only serves to make entries less visible for my usage.
How it was verified
Build
Forked off
main, made the changes in this feature branch (PR base), then built with:Unrelated to this PR's changes, but for transparency regarding the build command:
build/CMakeCache.txtgets created withCMAKE_EXPORT_COMPILE_COMMANDSunset which causescompile_commands.jsonto not be generated, resulting in clangd failing to find the compilation database and missing Qt include paths.-DCMAKE_EXPORT_COMPILE_COMMANDS=ONwas passed as an argument to allow IDE linting to function properly.Testing
The resulting build was tested visually with both:
where the Preferences toggle and opacity application was tested for both hidden and regular files and folders. Opacity application was observed alongside various combinations of other options and confirmed to be consistent throughout, including with
showHidden,expandableFolders,dateFormat, andfolderItemCount. Ensured opacity respectedopaqueHiddenacross all three view types (compact, details, icons), applied correctly when toggled with split panes open, and the visual appearance aligned with expectations across light and dark modes.Offscreen testing was performed via:
which passed (
run.logwas empty).Confirmed
opaqueHidden=truewas written to~/.config/astra-atlas/atlas.confunder[preferences], and that the value was applied accordingly across application restart.Demo
atlas_hidden_opacity_demo-compressed.mp4