Skip to content

fix(appimage): Wayland drop + allow extension-less AppImages - #38

Merged
dim-ghub merged 1 commit into
AstraSuite:mainfrom
swopnil7:fix-appimage-drop
Aug 28, 2026
Merged

dim-ghub merged 1 commit into
AstraSuite:mainfrom
swopnil7:fix-appimage-drop

Conversation

@swopnil7

Copy link
Copy Markdown
Contributor

Fixes drop-zone not firing on Hyprland/Wayland and restores real AppImage metadata. Fixes #33

Problem

  • DropArea keys: ["text/uri-list"] never matched Wayland drag keys → containsDrag false, onDropped never fired (100/sec qt.quick.* log spam hid the miss)
  • Missing drag.accept(Qt.CopyAction) / drop.acceptProposedAction() discarded Wayland drops
  • Global DropArea after Astra stole drops hiding AppImagePage highlight
  • Suffix-only filter rejected extension-less ELF AppImages (e.g. AppImageUpdate)
  • generateDesktopFile always wrote Comment=Installed via Foundry / Categories=Utility;

Fix

  • qml/Main.qml / qml/AppImagePage.qml: remove keys, add onEntered accept, acceptProposedAction, reorder global handler behind Astra
  • src/marketplace/appimageinstaller.cpp: hasElfMagic() (0x7F ELF) allows extension-less while rejecting .txt/.png, preserve embedded Comment/GenericName/Categories from squashfs-root/*.desktop

DropArea keys broke Hyprland/Wayland; add drag.accept and reorder handler, allow ELF extension-less AppImages while rejecting non-ELF, preserve embedded desktop Comment/Categories.
@dim-ghub
dim-ghub merged commit 48b5f59 into AstraSuite:main Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not able to install .AppImages by dragging them into Foundry

2 participants