bump oa-configurator to 1.2.1 - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins
oa-configurator>=1.2.1and refreshes the lock.1.2.1 carries the
safe_endpointfragment fix (oa-configurator #32). Before it, aURL fragment was passed through verbatim, so a
ProviderConfig.base_urlofrendered in the inspection tree with the token intact — the query string was
masked, the fragment was not. The OAuth implicit flow delivers access tokens in
exactly that position. 1.2.1 masks a non-empty fragment whole, to
#***.This matters here because
snapshot()routesProviderConfig.base_urlthroughsafe_endpoint, so groundskeeping inherited the gap directly.>=1.2wouldhave resolved to 1.2.0 and kept it.
No test is added in this PR. The behaviour is covered upstream in
oa-configurator's own suite, and the rendering path that consumes it is already
covered by
test_provider_base_url_is_masked_through_safe_endpoint.Dependency and lock only — no source changes.
🤖 Generated with Claude Code