Skip to content

Fix internal API usage - #387

Open
hatzlj wants to merge 1 commit into
mainfrom
enhancement/internal-api-usage
Open

hatzlj wants to merge 1 commit into
mainfrom
enhancement/internal-api-usage

Conversation

@hatzlj

@hatzlj hatzlj commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

as of https://platform.jetbrains.com/t/pluginmanagercore-getplugin-is-now-internal/4272 PluginManagerCore.getPlugin is considered internal API, recommending the approach in this PR to determine the plugin version.

@hatzlj hatzlj self-assigned this Sep 22, 2026
@hatzlj
hatzlj requested a review from a team as a code owner September 22, 2026 09:32
@hatzlj
hatzlj requested review from MateuszNaKodach, abuijze and smcvb and removed request for a team September 22, 2026 09:32

@CodeDrivenMitch CodeDrivenMitch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I read in the thread there are several ways to get the version, the current one being internal now. Seems to plan to introduce something different.

I want to say that continuing to use internal API does not break the build in the future, nor newer intellij versions using the current plugin version. They will only reject new occurrences of internal API usage, let's say, if we make a new class.

It would break if they rename/move the class, but it does not seem that that's the case

So I'm alright with merging this method, but we could also wait until their official solution. There's really no rush, as they won't punish us for keeping it.

@hatzlj

hatzlj commented Sep 25, 2026

Copy link
Copy Markdown
Contributor Author

As I read in the thread there are several ways to get the version, the current one being internal now. Seems to plan to introduce something different.

I want to say that continuing to use internal API does not break the build in the future, nor newer intellij versions using the current plugin version. They will only reject new occurrences of internal API usage, let's say, if we make a new class.

It would break if they rename/move the class, but it does not seem that that's the case

Thats true, my main reason to fix it again was that it broke our "Verify Plugin" step (see https://github.com/AxonFramework/IdeaPlugin/actions/runs/35622065262/job/106407282152) on dependabot PRs every time such a move occurs. But you're right, we don't need to fix it right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants