[2/3] Harden E2E state, cleanup, and Arc diagnostics - #288
Draft
Alex Huang (wenhug) wants to merge 2 commits into
Draft
[2/3] Harden E2E state, cleanup, and Arc diagnostics#288Alex Huang (wenhug) wants to merge 2 commits into
Alex Huang (wenhug) wants to merge 2 commits into
Conversation
This was referenced Aug 25, 2026
Alex Huang (wenhug)
temporarily deployed
to
e2e-testing
August 25, 2026 20:39 — with
GitHub Actions
Inactive
Alex Huang (wenhug)
force-pushed
the
wenhug/e2e-cleanup-hardening
branch
from
August 26, 2026 18:13
9b1d5f2 to
962f5c7
Compare
Alex Huang (wenhug)
force-pushed
the
wenhug/e2e-cleanup-hardening
branch
from
August 26, 2026 22:41
962f5c7 to
e2c8fec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stack
This branch targets
wenhug/bootstrap-rbac-coreso the review shows only E2E hardening and Arc bootstrap diagnostics. After #287 merges, it will be rebased and retargeted tomain.Scope
Successful shipped Flex Node behavior is unchanged. The bootstrap-data client now exposes only allowlisted, size-bounded, control-character-sanitized ARM error fields and request IDs on failed HTTP responses. The remaining changes are E2E state, infrastructure, cleanup, verification, and test code.
The extensive tests use fake Azure commands to exercise ownership validation, retries, concurrency, partial provisioning, residual detection, deletion ordering, role-assignment verification, and secret-safe failure reporting.
Validation
make checkgo test -race ./hack/e2ego test -race ./pkg/bootstrapdatabash -n