Skip to content

[2/3] Harden E2E state, cleanup, and Arc diagnostics - #288

Draft
Alex Huang (wenhug) wants to merge 2 commits into
wenhug/bootstrap-rbac-corefrom
wenhug/e2e-cleanup-hardening
Draft

[2/3] Harden E2E state, cleanup, and Arc diagnostics#288
Alex Huang (wenhug) wants to merge 2 commits into
wenhug/bootstrap-rbac-corefrom
wenhug/e2e-cleanup-hardening

Conversation

@wenhug

@wenhug Alex Huang (wenhug) commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • isolate every E2E attempt with deterministic names and ownership metadata
  • persist deployment state atomically and preserve it until cleanup is verified
  • make Azure cleanup fail closed, bounded, idempotent, and safe under partial deployment
  • handle AKS-managed node resource groups and legacy untagged OS disks
  • upload sanitized cleanup diagnostics and retain failed-attempt state
  • pin and recover the exact Kubernetes patch version across commands
  • verify the Arc principal, role, cluster scope, and role action before persisting assignment state
  • report bounded, redacted ARM error details and periodic Arc authorization health while bootstrap data is retried

Stack

This branch targets wenhug/bootstrap-rbac-core so the review shows only E2E hardening and Arc bootstrap diagnostics. After #287 merges, it will be rebased and retargeted to main.

Scope

Successful shipped Flex Node behavior is unchanged. The bootstrap-data client now exposes only allowlisted, size-bounded, control-character-sanitized ARM error fields and request IDs on failed HTTP responses. The remaining changes are E2E state, infrastructure, cleanup, verification, and test code.

The extensive tests use fake Azure commands to exercise ownership validation, retries, concurrency, partial provisioning, residual detection, deletion ordering, role-assignment verification, and secret-safe failure reporting.

Validation

  • make check
  • go test -race ./hack/e2e
  • go test -race ./pkg/bootstrapdata
  • Bicep compilation
  • workflow YAML parsing
  • ShellCheck and bash -n
  • independent pre-push scope, correctness, and security audit

@wenhug Alex Huang (wenhug) changed the title [2/3] Harden E2E state and Azure cleanup [2/3] Harden E2E state, cleanup, and Arc diagnostics Aug 25, 2026
@wenhug
Alex Huang (wenhug) force-pushed the wenhug/e2e-cleanup-hardening branch from 9b1d5f2 to 962f5c7 Compare August 26, 2026 18:13
@wenhug
Alex Huang (wenhug) force-pushed the wenhug/e2e-cleanup-hardening branch from 962f5c7 to e2c8fec Compare August 26, 2026 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant