Skip to content

Fix SAS examples with valid base64 keys - #148

Open
Leonidas Zhak (LeonidasZhak) wants to merge 1 commit into
Azure:masterfrom
LeonidasZhak:fix/sas-example-openssl-147
Open

Leonidas Zhak (LeonidasZhak) wants to merge 1 commit into
Azure:masterfrom
LeonidasZhak:fix/sas-example-openssl-147

Conversation

@LeonidasZhak

Copy link
Copy Markdown

Summary

Use a valid base64-encoded dummy account key in the get_account_sas() examples so R CMD check succeeds with openssl 2.5.0.

Thanks to maintainers

Thanks for reporting the CRAN example failure and for maintaining AzureStor.

Issue or motivation

Addresses #147. The package's help examples fail when the stricter openssl decoder encounters the placeholder key.

Root cause

The examples pass the literal access_key, which is not valid base64. Azure account keys are decoded before the SAS signature is created.

Change

Create one base64-encoded dummy key and reuse it in the direct and endpoint examples. Add a database-free regression test for both call paths.

Tests

  • Reproduced the reported failure with openssl 2.5.0; both corrected call paths now return a SAS.
  • Focused test: 2 expectations passed.
  • R CMD build: passed.
  • R CMD check --as-cran --no-manual on macOS/R 4.6.1: 0 errors, 0 warnings, 1 existing NOTE (R6 is declared in Imports but not imported).
  • Full package tests, examples, and vignettes passed. Azure credential and Azurite integration tests were skipped by the repository's existing environment guards.

Scope

Documentation examples, generated Rd, and regression coverage only. SAS signing behavior and Azure service integration are unchanged.

Closes #147.

@LeonidasZhak

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Urgent: test broken with openssl 2.5.0

1 participant