Repository navigation
Fix SAS examples with valid base64 keys - #148
Open
Leonidas Zhak (LeonidasZhak) wants to merge 1 commit into
Open
Leonidas Zhak (LeonidasZhak) wants to merge 1 commit into
Leonidas Zhak (LeonidasZhak) wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use a valid base64-encoded dummy account key in the
get_account_sas()examples soR CMD checksucceeds with openssl 2.5.0.Thanks to maintainers
Thanks for reporting the CRAN example failure and for maintaining AzureStor.
Issue or motivation
Addresses #147. The package's help examples fail when the stricter openssl decoder encounters the placeholder key.
Root cause
The examples pass the literal
access_key, which is not valid base64. Azure account keys are decoded before the SAS signature is created.Change
Create one base64-encoded dummy key and reuse it in the direct and endpoint examples. Add a database-free regression test for both call paths.
Tests
R CMD build: passed.R CMD check --as-cran --no-manualon macOS/R 4.6.1: 0 errors, 0 warnings, 1 existing NOTE (R6is declared in Imports but not imported).Scope
Documentation examples, generated Rd, and regression coverage only. SAS signing behavior and Azure service integration are unchanged.
Closes #147.