feat: improve configmap lifecycle handling - #242
Merged
Conversation
Add configurable QPS, burst, batch size, and total limits to ConfigMap deletion. Reconstruct deterministic ConfigMap names to avoid listing all objects, delete them concurrently in batches, and stop when the existing set is exhausted.
| } | ||
| totalDeleted += int(succeeded) | ||
|
|
||
| // Fewer successes than requests means this batch reached a NotFound entry. |
Collaborator
There was a problem hiding this comment.
I don't think we should do this check here.
Collaborator
There was a problem hiding this comment.
It's hard to follow the logic. just let the for condition decide when we can break.
Contributor
Author
There was a problem hiding this comment.
good call! move to the for condition and tested!
Fu Wei (fuweid)
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add configurable QPS, burst, batch size, and total limits to ConfigMap deletion. Reconstruct deterministic ConfigMap names to avoid listing all objects, delete them concurrently in batches, and stop when the existing set is exhausted.