Repository navigation
[Java] Move @azure-tools/typespec-java to typespec-azure repo
#4591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
4b89f7b
initial commit to migrate autorest.java to typespec-azure
srnagar 541efbe
Update typespec-java change version and packages
srnagar 0c783f9
merge from main
srnagar 0df8b51
add label
srnagar e6dbff7
update pnpm-lock.yaml
srnagar 50eef7f
linting errors
srnagar 909038a
fix catalog dependencies
srnagar 623cda6
update lock file
srnagar 518231b
cspell fix
srnagar 3df4d87
version consistency
srnagar 1f7faac
catalog version
srnagar a0c91f6
build core java gen
srnagar 910a108
no transfer progress logs
srnagar cce328e
skip spotless
srnagar 47ab7d3
Merge remote-tracking branch 'upstream/main' into typespec-java
srnagar 06fd3a3
fix linting
srnagar 966c20a
update tsconfig
srnagar b0f632f
ignore typespec-java package from eslint
srnagar 6421dd5
cleanup
srnagar 46818d5
remove redundant package.json
srnagar 80b46bb
remove old tests
srnagar 772f07c
Merge branch 'main' into typespec-java
srnagar b1165df
update build
srnagar f821baa
update build command
srnagar 327863b
ignore build artifacts
srnagar cb97a4c
merge from main
srnagar 93873cc
fix lock file
srnagar 0f44c37
fix linting
srnagar 36adeb1
Merge remote-tracking branch 'upstream/main' into typespec-java
srnagar fdb8f65
address comments
srnagar a0d05ad
include ts files
srnagar 82454ec
update copy target
srnagar 1d92a9b
fix build
srnagar 717054d
remove eng
srnagar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| --- | ||
| # Change versionKind to one of: internal, fix, dependencies, feature, deprecation, breaking | ||
| changeKind: internal | ||
| packages: | ||
| - "@azure-tools/typespec-java" | ||
| --- | ||
|
|
||
| [Java] Move `@azure-tools/typespec-java` to typespec-azure repo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| name: "typespec-java / CI" | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: | ||
| - main | ||
| - release/* | ||
| paths: | ||
| - "packages/typespec-java/**" | ||
| - ".github/workflows/ci-java.yml" | ||
| merge_group: | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| build: | ||
| name: Build | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| submodules: recursive | ||
| - uses: ./.github/actions/setup | ||
| - name: Install dependencies | ||
| run: pnpm install | ||
| - name: Build typespec-java package | ||
| run: pnpm turbo run --filter "@azure-tools/typespec-java..." build | ||
| lint: | ||
| name: Lint | ||
| runs-on: ubuntu-latest | ||
| needs: build | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| submodules: recursive | ||
| - uses: ./.github/actions/setup | ||
| - name: Install dependencies | ||
| run: pnpm install | ||
| - name: Run linters | ||
| working-directory: packages/typespec-java | ||
| run: pnpm lint |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| [tools] | ||
| python = "3.12" | ||
| uv = "latest" | ||
| java = "microsoft-11" | ||
| maven = "3.9.16" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| # Development | ||
|
|
||
| The emitter is the [TypeSpec](https://typespec.io/) library for emitting Java client from the TypeSpec REST protocol binding. | ||
|
|
||
| See [Emitter](https://typespec.io/docs/extending-typespec/emitters-basics/) for the basics on the TypeSpec emitter library. | ||
|
|
||
| See [Developer Guide for TypeSpec Emitter](docs/developer/typespec/readme.md) for basics on this repository. | ||
|
|
||
| Guideline: | ||
|
|
||
| - Most of the development work should happen in "core/packages/http-client-java" folder. | ||
| - Before starting the development in "core" folder, always checkout latest code from main branch, and create a dev branch upon it. | ||
| - When checking in code in "core" folder, do not check-in the files in "core.patch". | ||
| - When preparing the PR, create 2 PRs, one for the code changes in submodule ("typespec" repository, if there is change), one for the code changes in this repository (which would include the update on "core" submodule). | ||
|
|
||
| ## TypeScript Part for the Emitter | ||
|
|
||
| TypeScript code for the Emitter is in "core/packages/http-client-java/emitter" folder. Follow the package.json for the build and unit test. | ||
|
|
||
| The code there, in runtime, produces a "code-model.yaml" file, and passes it to Java Part to generate Java client. | ||
|
|
||
| ## Java Part for the Emitter | ||
|
|
||
| Java code for the Emitter is in "core/packages/http-client-java/generator/http-client-generator" (which depends on "http-client-generator-core" and "http-client-generator-mgmt" module). Follow the pom.xml for the build and unit test. | ||
|
|
||
| The code there, in runtime, consumes the "code-model.yaml" file produced by the TypeSpec Part, and generate the Java client. | ||
|
|
||
| # Update and Release | ||
|
|
||
| ## Update Node.js Package for Latest Dependencies | ||
|
|
||
| Instructions: | ||
|
|
||
| - Always use absolute path when change directory. | ||
|
|
||
| Steps: | ||
|
|
||
| 1. In "core" folder, run `git pull upstream main` to fetch latest commit from upstream or origin. | ||
| 2. Go back to project root. Commit the change in "core" folder. | ||
| 3. Run `ncu -u` on "package.json" in both "package.json" from "typespec-extension" and "typespec-tests" folder. | ||
| 4. Update package versions in `peerDependencies` (keep the semver range) in "package.json" from "typespec-extension" folder, according to the corresponding package versions in `devDependencies`. | ||
| 5. Update version of "@azure-tools/openai-typespec" lib in "package.json" from "typespec-extension" folder, set it to the same semantic version used in https://raw.githubusercontent.com/Azure/azure-rest-api-specs/refs/heads/main/package.json | ||
| 6. Update package versions in `override` (keep the semver range) in "package.json" from "typespec-tests" folder, according to the corresponding package versions in "package.json" from "typespec-extension" folder. | ||
| 7. Save the files, and run `npm install` in "typespec-extension" folder, so that "package-lock.json" would be updated. | ||
| 8. Run `npm audit fix` in "typespec-extension" folder. | ||
| 9. Commit the changes in "typespec-extension" and "typespec-tests" folders. | ||
| 10. Run `pwsh SyncTests.ps1` in "typespec-tests" folder. | ||
| 11. Commit the changes in "typespec-tests" folder, include new files. | ||
|
|
||
| ## Prepare for Minor/Patch Release | ||
|
|
||
| Steps: | ||
|
|
||
| 1. Bump minor/patch version of `@typespec/typespec-java` in both "package.json" from "typespec-extension" and "typespec-tests" folder. | ||
| 2. Save the file, and run `npm install` in "typespec-extension" folder, so that "package-lock.json" would be updated. | ||
| 3. Add a new item in release history in "typespec-extension/changelog.md". The version would be the minor/patch version. The date would be today. | ||
|
|
||
| The [publish to NPM pipeline](https://dev.azure.com/azure-sdk/internal/_build?definitionId=5618) needs to be triggered, after the PR is merged. | ||
|
|
||
| After release, the [sync SDK pipeline](https://dev.azure.com/azure-sdk/internal/_build?definitionId=6270) needs to be triggered, to sync the released typespec-java into the SDK repository. | ||
| This pipeline also regenerates all SDK based on TypeSpec. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.